rofi: use mkTarget

[0xda157]

Things done

• Tested locally
• Tested in testbed
• Commit message follows commit convention
• Fits style guide
• Respects license of any existing code used

Notify maintainers

[danth]

LGTM

[servaasvdc]

In fonts.size.popups, should it be sizes instead of size?

I'm a super new Nix user so I'm hesitant, but I'm getting errors when integrating rofi and stylix:

       error: attribute 'size' missing
       at /nix/store/qwgmn4jsy1m17rgjpfiqlqc1chqqvmar-source/modules/rofi/hm.nix:15:66:
           14|       {
           15|         programs.rofi.font = "${fonts.monospace.name} ${toString fonts.size.popups}";
             |                                                                  ^
           16|       }

And based on the stylix docs for nixos I have the impression it should be sizes.

[VuiMuich]

In fonts.size.popups, should it be sizes instead of size?

I'm a super new Nix user so I'm hesitant, but I'm getting errors when integrating rofi and stylix:

       error: attribute 'size' missing
       at /nix/store/qwgmn4jsy1m17rgjpfiqlqc1chqqvmar-source/modules/rofi/hm.nix:15:66:
           14|       {
           15|         programs.rofi.font = "${fonts.monospace.name} ${toString fonts.size.popups}";
             |                                                                  ^
           16|       }

And based on the stylix docs for nixos I have the impression it should be sizes.

I am seeing the same error and as I am using lix it also suggests to use sizes:

┏━ 1 Errors:
┃ error:
┃        … while evaluating an expression to select 'drvPath' on it
┃          at «internal»:1:552:
┃        … while evaluating strict
┃          at «internal»:1:552:
┃        (stack trace truncated; use '--show-trace' to show the full trace)
┃
┃        error: attribute 'size' missing
┃        at /nix/store/qwgmn4jsy1m17rgjpfiqlqc1chqqvmar-source/modules/rofi/hm.nix:15:72:
┃            14|       {
┃            15|         programs.rofi.font = "${fonts.monospace.name} ${toString fonts.size.popups}";
┃              |                                                                        ^
┃            16|       }
┃        Did you mean sizes?
┣━━━
┗━ ∑ ⚠ Exited with 1 errors reported by nix at 17:03:43 after 28s

I use this little overlay right now, which builds the derivation, but somehow now rofi theme is created by stylix:
I tried to fix this with this patch overlay, but somehow it does not apply the patch (the previous success was a false positive as I had set stylix.targets.rofi.enable = false 🤦‍♂️):

fixups = final: prev: {
     stylix = prev.stylix.overrideAttrs (oldAttrs: {
        patches = (oldAttrs.patches or []) ++ [
          (final.writeText "stylix-rofi-font-fix.patch" ''
            diff --git a/modules/rofi/hm.nix b/modules/rofi/hm.nix
            index abcdef0..1234567 100644
            --- a/modules/rofi/hm.nix
            +++ b/modules/rofi/hm.nix
            @@ -15,7 +15,7 @@
             {
               programs.rofi.font =
            -    "\$\{fonts.monospace.name\} \$\{toString fonts.size.popups\}";
            +    "\$\{fonts.monospace.name\} \$\{toString fonts.sizes.popups\}";
             }
          '')
        ];
      });
};

[stylix-automation]

Successfully created backport PR for release-25.05:

• [release-25.05] rofi: use mkTarget #1557