stylix: allow mkTarget's configuration arguments to receive paths#1523
Merged
trueNAHO merged 1 commit intonix-community:masterfrom Jun 26, 2025
Conversation
trueNAHO
force-pushed
the
stylix-allow-mktarget-s-configelements-argument-to-receive-paths
branch
2 times, most recently
from
92465f4 to
0c9eea2
Compare
trueNAHO
commented
Jun 20, 2025
trueNAHO
force-pushed
the
stylix-allow-mktarget-s-configelements-argument-to-receive-paths
branch
from
0c9eea2 to
bdaed50
Compare
trueNAHO
force-pushed
the
stylix-allow-mktarget-s-configelements-argument-to-receive-paths
branch
from
bdaed50 to
c952d40
Compare
0xda157
reviewed
Jun 21, 2025
trueNAHO
force-pushed
the
stylix-allow-mktarget-s-configelements-argument-to-receive-paths
branch
from
c952d40 to
9e24013
Compare
Flameopathic
approved these changes
Jun 24, 2025
Contributor
Flameopathic
left a comment
Flameopathic
left a comment
There was a problem hiding this comment.
This looks good as-is, though it may be nice for generalConfig to be able to do this as well.
trueNAHO
force-pushed
the
stylix-allow-mktarget-s-configelements-argument-to-receive-paths
branch
from
9e24013 to
7f058e4
Compare
Member
Author
True. I added the same For reference, I have tested this patch by applying diff --git a/modules/blender/hm.nix b/modules/blender/hm.nix
index 1503448..a3e7993 100644
--- a/modules/blender/hm.nix
+++ b/modules/blender/hm.nix
@@ -14,8 +14,8 @@ mkTarget {
};
configElements = [
- (import ./color-theme.nix)
- (import ./font-theme.nix)
+ ./color-theme.nix
+ ./font-theme.nix
(
{ cfg }:
{ |
Allow mkTarget's configElements and generalConfig arguments to receive paths, streamlining the migration away from the config.lib.stylix.colors function that depends on base16.nix [1] [2]. [1]: nix-community#159 (comment) [2]: nix-community#249 (comment)
trueNAHO
force-pushed
the
stylix-allow-mktarget-s-configelements-argument-to-receive-paths
branch
from
7f058e4 to
a6fb536
Compare
trueNAHO
changed the title
Flameopathic
approved these changes
Jun 25, 2025
stylix-automation bot
pushed a commit
that referenced
this pull request
Jun 26, 2025
) Allow mkTarget's configElements and generalConfig arguments to receive paths, streamlining the migration away from the config.lib.stylix.colors function that depends on base16.nix [1] [2]. [1]: #159 (comment) [2]: #249 (comment) Link: #1523 Reviewed-by: Flameopathic <64027365+Flameopathic@users.noreply.github.com> Reviewed-by: awwpotato <awwpotato@voidq.com> (cherry picked from commit c700d41)
Contributor
|
Successfully created backport PR for |
trueNAHO
added a commit
that referenced
this pull request
Jun 26, 2025
) Allow mkTarget's configElements and generalConfig arguments to receive paths, streamlining the migration away from the config.lib.stylix.colors function that depends on base16.nix [1] [2]. [1]: #159 (comment) [2]: #249 (comment) Link: #1523 Reviewed-by: Flameopathic <64027365+Flameopathic@users.noreply.github.com> Reviewed-by: awwpotato <awwpotato@voidq.com> (cherry picked from commit c700d41)
LunaCOLON3
pushed a commit
to LunaCOLON3/stylix
that referenced
this pull request
Jul 14, 2025
…x-community#1523) Allow mkTarget's configElements and generalConfig arguments to receive paths, streamlining the migration away from the config.lib.stylix.colors function that depends on base16.nix [1] [2]. [1]: nix-community#159 (comment) [2]: nix-community#249 (comment) Link: nix-community#1523 Reviewed-by: Flameopathic <64027365+Flameopathic@users.noreply.github.com> Reviewed-by: awwpotato <awwpotato@voidq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves the concern raised in #1509 (comment).
Things done
Notify maintainers
@Flameopathic