Skip to content

stylix: extract testbed modules to autoload.nix#1520

Merged
trueNAHO merged 1 commit intonix-community:masterfrom
MattSturgeon:testbed/split
Jun 25, 2025
Merged

stylix: extract testbed modules to autoload.nix#1520
trueNAHO merged 1 commit intonix-community:masterfrom
MattSturgeon:testbed/split

Conversation

@MattSturgeon
Copy link
Copy Markdown
Member

@MattSturgeon MattSturgeon commented Jun 19, 2025

Evaluated the set of testbed modules in a separate file from where we create the testbed NixOS systems.

The first file (autoload.nix) has no dependency on any of Stylix's flake inputs. The second file (default.nix) takes the autoloaded matrix as a parameter, then imports each module into a NixOS system (and test script wrapper).

This will enable a partitioned flake to evaluate the set of testbeds without needing to fully convert them into NixOS systems with dependencies on dev-inputs. See #1289.

Things done

  • Tested locally
    • Checked nix flake show still produces sane output
  • Tested in testbed
    • Spot tested some testbeds still build & run
  • Commit message follows commit convention
  • Fits style guide
  • Respects license of any existing code used

Notify maintainers

@awwpotato @trueNAHO @Flameopathic

@stylix-automation stylix-automation bot added the topic: testbed Testbed changes label Jun 19, 2025
Evaluated the set of testbed modules in a separate file from where we
create the testbed NixOS systems.

The first file (autoload.nix) has no dependency on any of Stylix's flake
inputs. The second file (default.nix) takes the matrix as a parameter,
then imports each module into a NixOS system, and wrapper script.

This will enable a partitioned flake to evaluate the set of testbeds
without needing to fully convert them into NixOS systems with
dependencies on dev-inputs.
@0xda157 0xda157 changed the title stylix: extract testbed modules to matrix.nix stylix: extract testbed modules to autoload.nix Jun 21, 2025
Copy link
Copy Markdown
Contributor

@0xda157 0xda157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@trueNAHO trueNAHO merged commit 1fc2289 into nix-community:master Jun 25, 2025
7 checks passed
@MattSturgeon MattSturgeon deleted the testbed/split branch June 25, 2025 09:49
@MattSturgeon
Copy link
Copy Markdown
Member Author

Thanks all for your time reviewing!

FYI if you plan to backport #1289, then this will also need backporting

stylix-automation bot pushed a commit that referenced this pull request Jun 26, 2025
Evaluated the set of testbed modules in a separate file from where we
create the testbed NixOS systems.

The first file (autoload.nix) has no dependency on any of Stylix's flake
inputs. The second file (default.nix) takes the matrix as a parameter,
then imports each module into a NixOS system, and wrapper script.

This will enable a partitioned flake to evaluate the set of testbeds
without needing to fully convert them into NixOS systems with
dependencies on dev-inputs.

Link: #1520

Reviewed-by: Flameopathic <64027365+Flameopathic@users.noreply.github.com>
Reviewed-by: awwpotato <awwpotato@voidq.com>
Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
(cherry picked from commit 1fc2289)
@stylix-automation
Copy link
Copy Markdown
Contributor

Successfully created backport PR for release-25.05:

0xda157 pushed a commit that referenced this pull request Jun 26, 2025
Evaluated the set of testbed modules in a separate file from where we
create the testbed NixOS systems.

The first file (autoload.nix) has no dependency on any of Stylix's flake
inputs. The second file (default.nix) takes the matrix as a parameter,
then imports each module into a NixOS system, and wrapper script.

This will enable a partitioned flake to evaluate the set of testbeds
without needing to fully convert them into NixOS systems with
dependencies on dev-inputs.

Link: #1520

Reviewed-by: Flameopathic <64027365+Flameopathic@users.noreply.github.com>
Reviewed-by: awwpotato <awwpotato@voidq.com>
Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
(cherry picked from commit 1fc2289)
LunaCOLON3 pushed a commit to LunaCOLON3/stylix that referenced this pull request Jul 14, 2025
Evaluated the set of testbed modules in a separate file from where we
create the testbed NixOS systems.

The first file (autoload.nix) has no dependency on any of Stylix's flake
inputs. The second file (default.nix) takes the matrix as a parameter,
then imports each module into a NixOS system, and wrapper script.

This will enable a partitioned flake to evaluate the set of testbeds
without needing to fully convert them into NixOS systems with
dependencies on dev-inputs.

Link: nix-community#1520

Reviewed-by: Flameopathic <64027365+Flameopathic@users.noreply.github.com>
Reviewed-by: awwpotato <awwpotato@voidq.com>
Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: testbed Testbed changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants