Skip to content

treewide: use config in literalExpressions#1517

Merged
trueNAHO merged 1 commit intonix-community:masterfrom
0xda157:defaultText-config
Jun 19, 2025
Merged

treewide: use config in literalExpressions#1517
trueNAHO merged 1 commit intonix-community:masterfrom
0xda157:defaultText-config

Conversation

@0xda157
Copy link
Copy Markdown
Contributor

@0xda157 0xda157 commented Jun 19, 2025

#1513 (comment)
cc @MattSturgeon

Things done

Notify maintainers

@trueNAHO trueNAHO merged commit 2b231cd into nix-community:master Jun 19, 2025
8 checks passed
stylix-automation bot pushed a commit that referenced this pull request Jun 19, 2025
Link: #1517

Reviewed-by: Matt Sturgeon <matt@sturgeon.me.uk>
Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
(cherry picked from commit 2b231cd)
@stylix-automation
Copy link
Copy Markdown
Contributor

Successfully created backport PR for release-25.05:

@0xda157 0xda157 deleted the defaultText-config branch June 19, 2025 19:54
0xda157 added a commit that referenced this pull request Jun 19, 2025
Link: #1517

Reviewed-by: Matt Sturgeon <matt@sturgeon.me.uk>
Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
(cherry picked from commit 2b231cd)
@MattSturgeon
Copy link
Copy Markdown
Member

MattSturgeon commented Jun 19, 2025

Looks like there's one more instance, this time in a literalMD:

stylix/stylix/palette.nix

Lines 134 to 137 in 2b231cd

defaultText = lib.literalMD ''
Automatically selected from the background image. The default will
throw if `stylix.image` is null.
'';

Maybe it doesn't need the config. prefix given it is used within a sentence.

Alternatively, maybe it should use the full option name by interpolating it? "${options.stylix.image}"

@0xda157 0xda157 mentioned this pull request Jun 21, 2025
5 tasks
trueNAHO pushed a commit that referenced this pull request Jun 23, 2025
Fixes: 2b231cd ("treewide: use config in literalExpressions (#1517)")
Link: #1529

Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
stylix-automation bot pushed a commit that referenced this pull request Jun 23, 2025
Fixes: 2b231cd ("treewide: use config in literalExpressions (#1517)")
Link: #1529

Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
(cherry picked from commit 67a6479)
trueNAHO pushed a commit that referenced this pull request Jun 23, 2025
Fixes: 2b231cd ("treewide: use config in literalExpressions (#1517)")
Link: #1529

Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
(cherry picked from commit 67a6479)
LunaCOLON3 pushed a commit to LunaCOLON3/stylix that referenced this pull request Jul 14, 2025
Fixes: 2b231cd ("treewide: use config in literalExpressions (nix-community#1517)")
Link: nix-community#1529

Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: home-manager Home Manager target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants