Skip to content

i3status-rust: use mkTarget#1465

Closed
0xda157 wants to merge 1 commit intonix-community:masterfrom
0xda157:i3status-rust-mkTarget
Closed

i3status-rust: use mkTarget#1465
0xda157 wants to merge 1 commit intonix-community:masterfrom
0xda157:i3status-rust-mkTarget

Conversation

@0xda157
Copy link
Copy Markdown
Contributor

@0xda157 0xda157 commented Jun 7, 2025

can't use configElements here to due to inf rec

Things done

Notify maintainers

@stylix-automation stylix-automation bot added the topic: home-manager Home Manager target label Jun 7, 2025
@0xda157
Copy link
Copy Markdown
Contributor Author

0xda157 commented Jun 7, 2025

can't use configElements here to due to inf rec

so much for that :/

@danth
Copy link
Copy Markdown
Member

danth commented Jun 7, 2025

I think this has infinite recursion because the value we're exporting is under config.lib, so it can't determine whether colors is null or not since that could be affected by the value inside the mkIf.

Could be fixed by renaming to a separate read-only option under the target, which would also help with documentation

@Flameopathic
Copy link
Copy Markdown
Contributor

Flameopathic commented Jun 30, 2025

I believe that this target can have its bars treated like the profiles of VSCode or Firefox; because the bars are configured through named attributes, this target could have a barNames option set up much the same as Firefox's profileNames. See

stylix/modules/i3/hm.nix

Lines 14 to 21 in 2a8e5e6

imports = [
(
{ config, ... }:
{
lib.stylix.i3.bar = builtins.warn "stylix: `config.lib.stylix.i3.bar` has been renamed to `config.stylix.targets.i3.exportedBarConfig`" config.stylix.targets.i3.exportedBarConfig;
}
)
];
for an example deprecating the use of a config.lib.stylix attribute.

@0xda157 0xda157 closed this Jul 28, 2025
@0xda157 0xda157 deleted the i3status-rust-mkTarget branch July 28, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: merge conflict Merge conflict topic: home-manager Home Manager target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants