Skip to content

gnome: fix xserver option renames#1429

Merged
danth merged 1 commit intonix-community:masterfrom
repparw:xserver-rename
Jun 1, 2025
Merged

gnome: fix xserver option renames#1429
danth merged 1 commit intonix-community:masterfrom
repparw:xserver-rename

Conversation

@repparw
Copy link
Copy Markdown
Contributor

@repparw repparw commented May 31, 2025

see #1416

@stylix-automation stylix-automation bot added the topic: nixos NixOS target label May 31, 2025
@danth
Copy link
Copy Markdown
Member

danth commented May 31, 2025

@repparw could you resolve the merge conflicts please?

@danth danth mentioned this pull request May 31, 2025
5 tasks
@repparw
Copy link
Copy Markdown
Contributor Author

repparw commented May 31, 2025

@danth think it's done now, haven't updated master in a while, mb

@stylix-automation stylix-automation bot added the topic: testbed Testbed changes label Jun 1, 2025
@repparw
Copy link
Copy Markdown
Contributor Author

repparw commented Jun 1, 2025

missed one

@repparw
Copy link
Copy Markdown
Contributor Author

repparw commented Jun 1, 2025

not figuring out what's happening here

@stylix-automation stylix-automation bot added the topic: dependencies Dependency updates label Jun 1, 2025
@repparw
Copy link
Copy Markdown
Contributor Author

repparw commented Jun 1, 2025

tests probably shouldn't explode if they find maintainers on both stylix and nixpkgs? dunno how to deal with that tho

@mightyiam
Copy link
Copy Markdown
Member

tests probably shouldn't explode if they find maintainers on both stylix and nixpkgs? dunno how to deal with that tho

I wouldn't bother trying to support that. Instead, remove the maintainer from stylix. My two cents.

Copy link
Copy Markdown
Member

@danth danth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I believe the maintainers check is intentional, to avoid having duplicated information.

@danth danth merged commit 48c4636 into nix-community:master Jun 1, 2025
5 checks passed
@repparw repparw deleted the xserver-rename branch June 1, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: dependencies Dependency updates topic: nixos NixOS target topic: testbed Testbed changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants