treewide: use mkTarget (batch 2)

[0xda157]

Things done

• Tested locally
• Tested in testbed
• Commit message follows commit convention
• Fits style guide
• Respects license of any existing code used

Notify maintainers

[trueNAHO]

this should be rebased or merge committed, DO NOT SQUASH so any problematic commits can be reverted.

-- #1342

I did not think of that before merging the previous batch with a merge commit, but in this case, it might be better to apply these treewide mkTarget changes in one commit to prevent littering the commit history with noisy <SCOPE>: use mkTarget commits. Using smaller commits to "trivially" revert /modules/<SCOPE>/ changes is still trivial with git checkout <HASH_OF_THIS_SQUASH_MERGE>~ modules/<SCOPE>/. IMHO, it would be better to sqaush merge this PR.

Splitting this treewide patchset into smaller patchet would make more sense in much larger projects, like the Linux Kernel, where each patch would be reviewed by entirely different submodule maintainers. However, our project is far from being this big and the core maintainers essentially just review the entire PR as a whole. The /module/<SCOPE>/meta.nix module maintainers are also not really involved in these treewide changes, making this use case somewhat non-existent in our case.

[0xda157]

this should be rebased or merge committed, DO NOT SQUASH so any problematic commits can be reverted.
-- #1342

I did not think of that before merging the previous batch with a merge commit, but in this case, it might be better to apply these treewide mkTarget changes in one commit to prevent littering the commit history with noisy <SCOPE>: use mkTarget commits. Using smaller commits to "trivially" revert /modules/<SCOPE>/ changes is still trivial with git checkout <HASH_OF_THIS_SQUASH_MERGE>~ modules/<SCOPE>/. IMHO, it would be better to sqaush merge this PR.

Didn't realize that it's possible to revert edits to a specific file with git, in that case this should be squashed.

[trueNAHO]

LGTM.

[stylix-automation]

Successfully created backport PR for release-25.05:

• [release-25.05] treewide: use mkTarget (batch 2) #1369

[repparw]

this broke tofi. removed lib from {...}, still used in a couple calls. lib.toHexString, couple more

[repparw]

@trueNAHO maybe revert tofi on branches as it doesnt build? (or throw a commit adding lib back, ig, dont see another problem)

[trueNAHO]

this broke tofi. removed lib from {...}, still used in a couple calls. lib.toHexString, couple more

@trueNAHO maybe revert tofi on branches as it doesnt build? (or throw a commit adding lib back, ig, dont see another problem)

@repparw, can you test #1370? That PR will be automatically merged after CI passes. Let me know if the issue is still not resolved after that.