Skip to content

helix: use theme option#1125

Closed
0xda157 wants to merge 1 commit intonix-community:masterfrom
0xda157:helix-programs
Closed

helix: use theme option#1125
0xda157 wants to merge 1 commit intonix-community:masterfrom
0xda157:helix-programs

Conversation

@0xda157
Copy link
Copy Markdown
Contributor

@0xda157 0xda157 commented Apr 9, 2025

as discussed in #481

Things done

Notify maintainers

@danth (based on blame)

@0xda157 0xda157 marked this pull request as draft April 9, 2025 17:14
@0xda157 0xda157 force-pushed the helix-programs branch 2 times, most recently from 03ad215 to 00ebe4d Compare April 9, 2025 18:32
@0xda157
Copy link
Copy Markdown
Contributor Author

0xda157 commented Apr 9, 2025

I had to convert the base16-helix template into nix

@0xda157 0xda157 force-pushed the helix-programs branch 2 times, most recently from 05b7b06 to 52acf90 Compare April 9, 2025 20:37
@Flameopathic
Copy link
Copy Markdown
Contributor

I think that it is better that we rely on outside templates for things like this because it, in general, keeps the templates more up-to-date than a Stylix contributor would. Consider opening a PR upstream for allowing this option to take strings and/or paths as well so that we can continue using base16-helix.

@trueNAHO
Copy link
Copy Markdown
Member

I think that it is better that we rely on outside templates for things like this because it, in general, keeps the templates more up-to-date than a Stylix contributor would. Consider opening a PR upstream for allowing this option to take strings and/or paths as well so that we can continue using base16-helix.

Yes, ideally .settings or .theme options would be upstreamed to platforms like Home Manager:

This issue covers a real tangible Stylix limitation that is planned to be resolved in the future.

is our plan of resolving this the same as in #481 as well, which is upstreaming options?

AFAIK, yes.

-- #704 (comment)

Since this is a huge undertaking there has not really been any progress on this. AFAIK nix-community/home-manager#6235 (comment) is the only time this has been upstreamed.

@0xda157 0xda157 changed the title helix: use programs.helix.themes helix: use theme option Apr 13, 2025
@0xda157 0xda157 marked this pull request as ready for review April 14, 2025 15:24
@trueNAHO trueNAHO mentioned this pull request Apr 20, 2025
5 tasks
Copy link
Copy Markdown
Member

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for upstreaming this.

This PR will be merged in #1146.

@trueNAHO trueNAHO closed this Apr 20, 2025
@0xda157 0xda157 deleted the helix-programs branch April 20, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants