Skip to content
This repository has been archived by the owner on Oct 7, 2022. It is now read-only.

Add support for passing extra env variables #97

Closed
wants to merge 1 commit into from

Conversation

edofic
Copy link
Contributor

@edofic edofic commented Jan 11, 2017

Bascause some funky setup.py files take arguments from the environment.
As far as I understand pypi2nix runs a pure nix-shell exactly to avoid variables like this so I created a new flag to explicitly pass settings in.


This change is Reviewable

@garbas
Copy link
Contributor

garbas commented Jan 27, 2017

@edofic sorry sorry sorry ... this PR completely skipped my radar. will look it over the next 2 days.

it looks ok but i would like to test it and maybe create a small example which we can use as a test

@garbas
Copy link
Contributor

garbas commented Jan 29, 2017

hmm might be also cool to be able to evaluate nix for extra_env. so that you could do something like: NIX_CFLAGS_COMPILE="-I${pkgs.cyrus_sasl.dev}/include/sasl" for python-ldap package

@garbas garbas closed this in f64e34f Jan 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants