Skip to content
This repository has been archived by the owner on Oct 7, 2022. It is now read-only.

Add cli option to include an override.nix file #109

Merged
merged 4 commits into from
Mar 18, 2017

Conversation

seppeljordan
Copy link
Contributor

@seppeljordan seppeljordan commented Feb 25, 2017

Users can now specify -O file://path/to/file to include an
additional overrides file.


This change is Reviewable

@seppeljordan
Copy link
Contributor Author

seppeljordan commented Feb 25, 2017

I would appreciate suggestions on how to test this feature automatically.

@seppeljordan
Copy link
Contributor Author

@garbas
I feel confident about the changes in this PR but I don't want to merge it yet. Could you look into this to see if it goes in a direction you approve?

Copy link
Contributor

@garbas garbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 for the new option. i haven't tested it but an example which tests this would is required when we introduce new functionality.

you can change an already existing example to use this -O option.

@seppeljordan
Copy link
Contributor Author

@garbas will do

@seppeljordan seppeljordan force-pushed the include-overrides branch 4 times, most recently from ac16ab6 to 7adda6e Compare March 6, 2017 21:35
@seppeljordan
Copy link
Contributor Author

@garbas for some reason, nix-prefech-git is not in path anymore and i don't know why. locally the tornado test passes.

@garbas
Copy link
Contributor

garbas commented Mar 13, 2017

@seppeljordan I think we need to fix this in default.nix and depend directly on nix-prefetch-git and nix-prefetch-hg instead of nix-prefetch-scripts.

@seppeljordan
Copy link
Contributor Author

okay, i solved the path issue in default.nix with wrapProgram --prefix PATH : /path/to/nix-prefetch-git but now we have a problem with scipy. i don't think that its an issue with this PR. The new connexion test makes use of the new feature. IMO we can merge this know. How do you feel about this, @garbas.

@seppeljordan seppeljordan merged commit f7199f0 into nix-community:master Mar 18, 2017
@seppeljordan seppeljordan deleted the include-overrides branch April 9, 2017 14:27
@garbas garbas modified the milestone: 1.8.0 Apr 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants