Skip to content

New bootstrap fixes#1290

Closed
K900 wants to merge 3 commits into
nix-community:masterfrom
K900:new-bootstrap-fixes
Closed

New bootstrap fixes#1290
K900 wants to merge 3 commits into
nix-community:masterfrom
K900:new-bootstrap-fixes

Conversation

@K900
Copy link
Copy Markdown
Contributor

@K900 K900 commented Aug 28, 2023

This gets things building, at least. We should probably figure out how to make these conditional on nixpkgs version though...

@K900 K900 force-pushed the new-bootstrap-fixes branch from 697ee81 to 77678e6 Compare August 28, 2023 07:58
@nixos-discourse
Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/psa-poetry2nix-is-currently-broken-with-nixpkgs-unstable/32281/1

Comment thread overrides/default.nix
);


# Stop infinite recursion by using bootstrapped pkg from nixpkgs
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those using poerty2nix with python2 projects may want to keep this

@tjni
Copy link
Copy Markdown

tjni commented Aug 28, 2023

I would be happy to help fix what's broken too. I should have checked this before merging, but I forgot. With that said, I might need some hand holding since I don't use poetry2nix.

Comment thread flake.lock
"owner": "NixOS",
"repo": "nixpkgs",
"rev": "2de8efefb6ce7f5e4e75bdf57376a96555986841",
"rev": "f900e733c1602b4c46064a9ef0514bb2345a8949",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say this makes it "conditional on nixpkg version". Otherwise there is lib.version which is a string :/

@KiruyaMomochi KiruyaMomochi mentioned this pull request Sep 1, 2023
@takeda
Copy link
Copy Markdown
Contributor

takeda commented Sep 18, 2023

What is the status of the fix? Do I need to include this patch if I want to use latest version of nixpkgs and poetry2nix?

@delroth
Copy link
Copy Markdown
Contributor

delroth commented Sep 18, 2023

What is the status of the fix? Do I need to include this patch if I want to use latest version of nixpkgs and poetry2nix?

You'll want to follow #1291 which has more info and status updates.

@K900
Copy link
Copy Markdown
Contributor Author

K900 commented Sep 22, 2023

I really don't have the time or the spoons to invest into this anymore. Anyone interested in picking this up, please do.

@K900
Copy link
Copy Markdown
Contributor Author

K900 commented Sep 25, 2023

I'll just close the PR because I really don't intend to work on this any time soon. Anyone willing to pick up the work is more than welcome to.

@K900 K900 closed this Sep 25, 2023
@sciyoshi sciyoshi mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants