Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lockfile 6.0 #26

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

thatsmydoing
Copy link

Fixes #25

Update pnpm2nix to use lockfile 6.0 and pnpm 8. I've not really used this in any real world project but all the tests seem to pass.

@Gerschtli
Copy link

Thank you for this PR! I found an issue with the dependency @sveltejs/[email protected] resulting in an error like

error:                                                                                                                                                                          
       … while calling the 'derivationStrict' builtin                                                                                                                           
                                                                                                                                                                                
         at //builtin/derivation.nix:9:12: (source not available)                                                                                                               
                                                                                                                                                                                
       … while evaluating derivation 'name-0.0.1'                                                                                                                               
         whose name attribute is located at /nix/store/i4ginw25yf2q0shnzvzjjwa58srbjhw7-source/pkgs/stdenv/generic/make-derivation.nix:300:7
                                                                                                                                                                                
       … while evaluating attribute 'buildInputs' of derivation 'name-0.0.1'
                                                                                                                                                                                
         at /nix/store/i4ginw25yf2q0shnzvzjjwa58srbjhw7-source/pkgs/stdenv/generic/make-derivation.nix:347:7:
                                                                                        
          346|       depsHostHost                = lib.elemAt (lib.elemAt dependencies 1) 0;
          347|       buildInputs                 = lib.elemAt (lib.elemAt dependencies 1) 1;
             |       ^                                                                  
          348|       depsTargetTarget            = lib.elemAt (lib.elemAt dependencies 2) 0;
                                                                                                                                                                                
       error: Constraint "^2.68.0||^3.0.0" could not be parsed

The mentioned constraint is in this block

  /@rollup/[email protected]([email protected]):
    resolution: {integrity: sha512-L92Vz9WUZXDnlQQl3EwbypJR4+DM2EbsO+/KOcEkP4Mc6Ct453EeDB2uH9lgRwj4w5yflgNpq9pHOiY8aoUXBQ==}
    engines: {node: '>=14.0.0'}
    peerDependencies:
      rollup: ^2.68.0||^3.0.0
    peerDependenciesMeta:
      rollup:
        optional: true
    dependencies:
      '@rollup/pluginutils': 5.0.4([email protected])
      commondir: 1.0.1
      estree-walker: 2.0.2
      glob: 8.1.0
      is-reference: 1.2.1
      magic-string: 0.27.0
      rollup: 3.28.1
    dev: false

@rollup/plugin-commonjs is a direct dependency of @sveltejs/adapter-node.

If you have any idea how to fix this, I would love to help :)

@thatsmydoing
Copy link
Author

I pushed a change that might fix it, see if it works?

@Gerschtli
Copy link

That fixed it, thank you :)

@Septias
Copy link

Septias commented Nov 16, 2023

can this be merged?

@bbigras
Copy link

bbigras commented Nov 29, 2023

@adisbladis friendly ping

@bbigras
Copy link

bbigras commented Nov 30, 2023

I got error: Constraint ">=0.11 <=16" could not be parsed

❯ rg "<=16"
pnpm-lock.yaml
6770:      graphql: '>=0.11 <=16'
6779:      graphql: '>=0.11 <=16'

@adisbladis
Copy link
Member

I don't particularly see any problems with this PR, but I also am not actively using pnpm anymore.
It would be best if someone who actually uses pnpm/pnpm2nix would take over maintenance.

@bbigras
Copy link

bbigras commented Nov 30, 2023

there's also https://github.com/nzbr/pnpm2nix-nzbr

and NixOS/nixpkgs#231513

@Septias
Copy link

Septias commented Nov 30, 2023

@adisbladis Why aren't you using pnpm anymore if I may ask?

@adisbladis
Copy link
Member

@adisbladis Why aren't you using pnpm anymore if I may ask?

I no longer work full time with JS/TS development and nodejs packaging needs are much simpler.

@adisbladis
Copy link
Member

I've updated the readme to indicate that the project is unmaintained, and looking for a new maintainer.
I'm also open to someone taking over the name with a new project.
cc @nzbr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support pnpm lockfileVersion: 6.0
5 participants