fix: convert the npm name to a nix name #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM just needs a test in the same fashion as https://github.com/tweag/npmlock2nix/blob/master/tests/make-source-urls.nix |
zimbatm
force-pushed
the
name-to-pname
branch
2 times, most recently
from
c66514a
to
d78b456
Compare
|
fixed! |
|
@zimbatm this doesn't add the test yet, does it? |
For example a namespaced npm package will be `@org/name` and converted to `?org?name`.
This adds tests for sanitizing derivation (and path to that extend) names to the valid (allowed) subset of characters.
andir
approved these changes
Aug 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example a namespaced npm package will be
@org/nameand convertedto
?org?name.Fixes #48