plugins/treesitter: support new api #4084
Conversation
4c7d3f5 to
e4a1f6e
Compare
GaetanLepage
left a comment
There was a problem hiding this comment.
I went through the diff and it seems great for starting the initial compat-implem. Good job!
e4a1f6e to
6dd3d90
Compare
4e95128 to
fd0c133
Compare
fd0c133 to
0d9d666
Compare
0d9d666 to
d072654
Compare
9cce6da to
a1a33bd
Compare
a1a33bd to
04b819e
Compare
04b819e to
2c730e7
Compare
|
@MattSturgeon Alright, just got back and applied those changes. Looks like warning and documentation looks right. |
2c730e7 to
3bc691b
Compare
b68e9c6 to
e594da2
Compare
Yeah, I also suspect is clear = true |
|
That wasn't intentional I meant to remove the module based one. |
|
I think we can have clear = true, with one augroup, if folding, highlight and indent are set together. |
IIUC, the (I think) |
|
I just noticed we are creating the same augroup two times, that is what is making it not work |
|
Yes, it was related a requested change above wanting them all to have a group. I meant to replace the module with the inline lua. It's just leftover code from a refactor. |
85511bb to
6307326
Compare
MattSturgeon
left a comment
There was a problem hiding this comment.
LGTM. Final questions, quibbles, suggestions:
aed6997 to
86807bd
Compare
|
alright, updated with suggested changes and added that additional note |
86807bd to
dc09097
Compare
New treesitter branch will have a completely new API. update to support both legacy and new apis
Just more consistent and intuitive.
Follow upstream recommendation for enabling folding.
dc09097 to
5b793a1
Compare
GaetanLepage
left a comment
There was a problem hiding this comment.
I went through the diff again. No issue on my side.
New treesitter branch will have a completely new API. update to support both legacy and new apis
Should add support for anyone using NixOS/nixpkgs#470883