plugins/barbar: add nullOr workaround for keymaps lua warning#3961
Merged
MattSturgeon merged 1 commit intonix-community:mainfrom Nov 21, 2025
Merged
plugins/barbar: add nullOr workaround for keymaps lua warning#3961MattSturgeon merged 1 commit intonix-community:mainfrom
MattSturgeon merged 1 commit intonix-community:mainfrom
Conversation
Currently, `types.either` has support for the new valueMeta attribute added by v2 check and merge, while `types.nullOr` does not. The `lua` option deprecation warning implemented in `modules/keymaps.nix` requires `valueMeta`, so re-implement `nullOr` using `types.either` as a workaround.
GaetanLepage
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3960.
Fixes the keymap
luadeprecation warning forplugins.barbar.keymaps.*.These options are the only ones that both support the deprecated
luafield and use anullOr submoduletype, making them the only ones affected.Currently,
types.nullOrdoes not propagate the newvalueMetaattribute added by v2 check and merge, buttypes.eitherdoes.Since the warning logic in
modules/keymaps.nixdepends onvalueMeta, this PR re-implementsnullOrusingtypes.eitheras a local workaround.