Skip to content

lib,lsp,none-ls: Add a standard way to handle automatic installation of packages that may not exist in nixpkgs#2852

Merged
mergify[bot] merged 1 commit intonix-community:mainfrom
traxys:lsp-err
Jan 31, 2025
Merged

lib,lsp,none-ls: Add a standard way to handle automatic installation of packages that may not exist in nixpkgs#2852
mergify[bot] merged 1 commit intonix-community:mainfrom
traxys:lsp-err

Conversation

@traxys
Copy link
Member

@traxys traxys commented Jan 17, 2025

If such a package is used by an end user an error will be raised with a message of the form:

       error: Nixvim (plugins.none-ls.sources.formatting.textlint.package): No package is known for textlint, install externally and set this option to null

I'm open to changing that to a warning and returning null instead, though this would complicate the implementation as we would now need to check the priorities

Copy link
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this is looking nicer.

Thanks for continuing to work on this!

@traxys traxys force-pushed the lsp-err branch 2 times, most recently from c22d889 to b8d9531 Compare January 30, 2025 22:25
Copy link
Member

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very nice !

Copy link
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Final nits and wording suggestions below:

@traxys traxys force-pushed the lsp-err branch 2 times, most recently from 1f380ed to c7e2829 Compare January 31, 2025 22:36
Copy link
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@traxys
Copy link
Member Author

traxys commented Jan 31, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jan 31, 2025

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at a2f0187

@mergify
Copy link
Contributor

mergify bot commented Jan 31, 2025

This pull request, with head sha a2f01876f721d3361f33845397de77ca19e5734a, has been successfully merged with fast-forward by Mergify.

This pull request will be automatically closed by GitHub.

As soon as GitHub detects that the sha a2f01876f721d3361f33845397de77ca19e5734a is part of the main branch, it will mark this pull request as merged.

It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch lsp-err, this means GitHub will fail to detect the merge.

@mergify mergify bot merged commit a2f0187 into nix-community:main Jan 31, 2025
2 checks passed
@mergify mergify bot temporarily deployed to github-pages January 31, 2025 23:02 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants