modules/output: obtain plugin configs from wrapped neovim#2414
modules/output: obtain plugin configs from wrapped neovim#2414mergify[bot] merged 3 commits intonix-community:mainfrom
Conversation
This test was removed in 3d1224a to remove IFD. Rewrite the test using `pkgs.runCommandLocal` and grep.
The official method for obtaining the generated initRc content is from wrapped neovim rather than from makeNeovimConfig helper. To use this approach: first wrap neovim with the generated config, then override it with our wrapperArgs.
GaetanLepage
left a comment
GaetanLepage
left a comment
There was a problem hiding this comment.
Thanks for taking care of this !
Diff LGTM but I'm not that familiar with this part of the codebase.
@nix-community/nixvim could you guys have a quick look ?
|
NixOS/nixpkgs#344541 merged ! |
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 767eb62 |
|
This pull request, with head sha This pull request will be automatically closed by GitHub.As soon as GitHub detects that the sha It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch |
3 participants
This:
makeNeovimConfig, generated config is obtained fromwrappedNeovim.initRc. This should avoid breaking after neovim: make the derivation more composable NixOS/nixpkgs#344541 is merged. See also conversation in test-teto-fork #2343.