Conversation
GaetanLepage
force-pushed
the
hex
branch
2 times, most recently
from
8392a5b to
5fb75a5
Compare
MattSturgeon
left a comment
MattSturgeon
left a comment
There was a problem hiding this comment.
I haven't checked the upstream plugin options, but the diff looks good and CI is green. Thanks!
plugins/by-name/hex/default.nix
Outdated
| xxdPackage = lib.mkPackageOption pkgs "xxd" { | ||
| default = [ | ||
| "unixtools" | ||
| "xxd" | ||
| ]; | ||
| nullable = true; | ||
| }; |
There was a problem hiding this comment.
Up to you, but when the name is the same as the last element of the default, you can also use mkPackageOption like this:
lib.mkPackageOption pkgs [
"unixtools"
"xxd"
] { nullable = true; }There was a problem hiding this comment.
Also note: you'll be pleased to hear nixfmt will start formatting this as the following soon:
lib.mkPackageOption pkgs [ "unixtools" "xxd" ] { nullable = true; }As short lists will be allowed to stay contracted when used as function arguments.
Just need NixOS/nixfmt#233 to make it to our nixpkgs lock 😁
There was a problem hiding this comment.
Up to you, but when the
nameis the same as the last element of thedefault, you can also usemkPackageOptionlike this:lib.mkPackageOption pkgs [ "unixtools" "xxd" ] { nullable = true; }
Good to know, I changed it.
|
@Mergifyio queue |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at ffa9b8f |
2 participants
Adds hex.nvim.
Fixes #2187