Skip to content

plugins/vim-autosource: init#2167

Merged
mergify[bot] merged 1 commit intonix-community:mainfrom
refaelsh:add-vim-autosource
Sep 5, 2024
Merged

plugins/vim-autosource: init#2167
mergify[bot] merged 1 commit intonix-community:mainfrom
refaelsh:add-vim-autosource

Conversation

@refaelsh
Copy link
Contributor

@refaelsh refaelsh commented Sep 4, 2024

@khaneliman khaneliman changed the title Ass vim-autosource plugins/vim-autosource: init Sep 4, 2024
@refaelsh
Copy link
Contributor Author

refaelsh commented Sep 5, 2024

enforcing formatting is part of our CI, and we can't merge PRs unless the CI passes.

I completly understand and agree with it. I think its a very good practice. I love it when people do it.

Copy link
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good. Thanks!

Are you able to squash/rebase?

@refaelsh
Copy link
Contributor Author

refaelsh commented Sep 5, 2024

Everything seems good. Thanks!

Are you able to squash/rebase?

Done.

package = "vim-autosource";
globalPrefix = "autosource_";

maintainers = [ lib.nixvim.maintainers.refaelsh ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: this can be:

Suggested change
maintainers = [ lib.nixvim.maintainers.refaelsh ];
maintainers = [ lib.maintainers.refaelsh ];

As the two are now actually aliases.

I won't block on this though, because we'll do a treewide cleanup at some point.

@MattSturgeon
Copy link
Member

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Sep 5, 2024

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 4df5746

@mergify mergify bot merged commit 4df5746 into nix-community:main Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants