Skip to content

unstable: update to gdtoolkit_4#1659

Closed
dezren39 wants to merge 1 commit intonix-community:mainfrom
developing-today-forks:main
Closed

unstable: update to gdtoolkit_4#1659
dezren39 wants to merge 1 commit intonix-community:mainfrom
developing-today-forks:main

Conversation

@dezren39
Copy link
Contributor

@dezren39 dezren39 commented Jun 9, 2024

there is now gdtoolkit_3 and gdtoolkit_4 in unstable
could also do

    gdformat = pkgs.gdtoolkit_3;
    gdlint = pkgs.gdtoolkit_3;
    gdformat_4 = pkgs.gdtoolkit_4;
    gdlint_4 = pkgs.gdtoolkit_4;

or

    gdformat_3 = pkgs.gdtoolkit_3;
    gdlint_3 = pkgs.gdtoolkit_3;
    gdformat_4 = pkgs.gdtoolkit_4;
    gdlint_4 = pkgs.gdtoolkit_4;

or maybe

    gdformat = pkgs.gdtoolkit_3;
    gdlint = pkgs.gdtoolkit_3;
    gdformat_3 = pkgs.gdtoolkit_3;
    gdlint_3 = pkgs.gdtoolkit_3;
    gdformat_4 = pkgs.gdtoolkit_4;
    gdlint_4 = pkgs.gdtoolkit_4;

and then somehow output a warning for gdformat and gdlint for a while before removing it

@dezren39 dezren39 closed this Jun 9, 2024
@dezren39 dezren39 reopened this Jun 9, 2024
@dezren39 dezren39 changed the title update to gdtoolkit_4 unstable: update to gdtoolkit_4 Jun 9, 2024
@dezren39
Copy link
Contributor Author

dezren39 commented Jun 9, 2024

resolves: #1660

@MattSturgeon
Copy link
Member

CI is failing with error: attribute 'gdtoolkit_4' missing.

there is now gdtoolkit_3 and gdtoolkit_4 in unstable

Was this a recent change? This PR might need to be held until after we update our flake.lock.


Also, your commit should be titled "plugins/none-ls: rename package gdformat to gdformat_4" to match our commit style (see the file's history for examples)

@Thiago-Assis-T
Copy link

I really don't follow, why is this breaking my build if I'm not using gdformat nor gdlint, I even removed the ts grammar, can you explain it to me? I'm confused

@MattSturgeon
Copy link
Member

MattSturgeon commented Jun 10, 2024

Please re-open if this is still an issue after our next flake.lock update.

See #1660 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments