overhaul most of nix-bundle#26
Merged
matthewbauer merged 1 commit intonix-community:masterfrom Mar 3, 2018
Merged
Conversation
pulled nix-user-chroot into the same repo put the startup command into a bash script, so the tarball job knows its deps changed nix-user-chroot into a c++ program added CLI flags to allow configuring the sandbox it produces
Contributor
|
$ nix build -f release.nix
$ ./result/bin/nix-bundle bash /bin/bash
error: getting attributes of path ‘/nix/store/xq6cia08kfg4y37b6wnjy3bid660swm0-nix-bundle-0.2.0/share/nix-bundle/nix-user-chroot’: No such file or directory
$ ls ./result/share/nix-bundle
AppRun.c appdir.nix appdir.sh appimage-top.nix appimage.nix appimagetool.nix default.nix nix-bundle.sh nix-run.sh nix2appimage.sh |
Member
|
Looks good! I can bump the version after this too. |
Member
|
Thanks! Error in #26 (comment) has also been fixed. |
Contributor
|
Oh, it was fixed separately in dcbfa1a :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pulled nix-user-chroot into the same repo
put the startup command into a bash script, so the tarball job knows its deps
changed nix-user-chroot into a c++ program
added CLI flags to allow configuring the sandbox it produces
with these changes, you can now configure it to do things like mapping the host /etc to /host-etc inside the namespace, and have finer control over how pure the env variables are