Skip to content

Use closureInfo instead of pathsFromGraph#120

Merged
Artturin merged 3 commits intonix-community:masterfrom
TroyNeubauer:fix-paths-from-graph
Sep 1, 2025
Merged

Use closureInfo instead of pathsFromGraph#120
Artturin merged 3 commits intonix-community:masterfrom
TroyNeubauer:fix-paths-from-graph

Conversation

@TroyNeubauer
Copy link
Copy Markdown
Contributor

@TroyNeubauer TroyNeubauer commented Apr 1, 2025

This PR recently removed pathsFromGraph. Switch to use closureInfo instead.

Testing:

troy@battlestation ~/n/nix-bundle (fix-paths-from-graph)> nix bundle --bundler github:TroyNeubauer/nix-bundle/84638f4 nixpkgs#hello --verbose --show-trace
unpacking 'github:TroyNeubauer/nix-bundle/84638f4a8cff38f7a023b2a89c5209cde5ed9534' into the Git cache...
building '/nix/store/s2iv6gxmdb5xwy4m7cwyii1z52z6a561-maketar.drv'...
building '/nix/store/61f86sn5va148l61pxhpgbn7dv55x9wg-hello-arx.drv'...
troy@battlestation ~/n/nix-bundle (fix-paths-from-graph)> ./hello-arx
Hello, world!

Copy link
Copy Markdown

@MultisampledNight MultisampledNight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with nix-bundle openssh /bin/ssh, works perfectly.

@dpc
Copy link
Copy Markdown
Contributor

dpc commented Aug 19, 2025

This is failing in our CI now, I think

error:
       … while calling the 'derivationStrict' builtin
         at <nix/derivation-internal.nix>:37:12:
           36|
           37|   strict = derivationStrict drvAttrs;
             |            ^
           38|

       … while evaluating derivation 'devimint-arx'
         whose name attribute is located at /nix/store/vjk8x60zj28wj5n07276s0cj7594bncn-source/pkgs/stdenv/generic/make-derivation.nix:480:13

       … while evaluating attribute 'buildCommand' of derivation 'devimint-arx'
         at /nix/store/rg7wfg8l79ashynpxywci4jaz92315w4-source/default.nix:22:7:
           21|       };
           22|       buildCommand = ''
             |       ^
           23|         # tmpdir has a additional `/` in the beginning to work around `QualifiedPath` checking for `|/|./|../|`

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: pathsFromGraph has been removed, use closureInfo instead

@TroyNeubauer
Copy link
Copy Markdown
Contributor Author

@dpc Does switching to my branch fix it?

@Artturin Artturin merged commit 649d77e into nix-community:master Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants