Skip to content

Comments

Use src as string and not store path to avoid IFD#5

Merged
nmattia merged 1 commit intomasterfrom
nm-dont-ifd
Nov 25, 2019
Merged

Use src as string and not store path to avoid IFD#5
nmattia merged 1 commit intomasterfrom
nm-dont-ifd

Conversation

@nmattia
Copy link
Collaborator

@nmattia nmattia commented Nov 25, 2019

No description provided.

@nmattia nmattia merged commit d9dc1b0 into master Nov 25, 2019
@nmattia nmattia deleted the nm-dont-ifd branch November 25, 2019 15:52
@ghost
Copy link

ghost commented Jan 10, 2020

This breaks building from derivations (if they haven't already been realized) instead of existing paths, any way to get that behavior back?

@nmattia
Copy link
Collaborator Author

nmattia commented Jan 10, 2020

@hyperfekt can you give a code example? I'll try to come up with a solution

@ghost
Copy link

ghost commented Jan 10, 2020

I tried adding rust-analyzer to the buildInputs but it did not help.

rust-analyzer = pkgs.fetchFromGitHub {
    owner = "rust-analyzer";
    repo = "rust-analyzer";
    rev = "ac7daf9cb9f6fcab5e561de2a43c6704868021e9";
    sha256 = "1x2cpyiyz6y7i52vqh3nk24vslazwd7a86pfzbnbwk4w0xry9ln2";
  };

  rust-analyzer-code = (napalm.buildPackage "${rust-analyzer}/editors/code" {
    name = "ra-lsp-0.0.1.zip";
    npmCommands = [
      "npm install"
      "patchShebangs node_modules"
      "node_modules/.bin/vsce package"
    ];
    installPhase = ''
      cp ra-lsp-0.0.1.vsix $out
    '';
  });

@ghost
Copy link

ghost commented Jan 10, 2020

Actually, it seems like this patch alone is not the culprit, and this usecase was never supported - although I'm not sure why, as readDir should be realizing the path.
Ergo this should probably be a feature request issue instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant