Closed
Conversation
`libtest` defaults to the number of cores which is often too much parallelism.
This is to work around a bug in `builtins.fetchGit` where specifying a `rev` which is not an ancestor of HEAD results in a git error. When setting `ref` to `rev` we force Nix to fetch the `rev`. TODO: This hack can be removed once the following is merged and released: NixOS/nix#3408
nmattia
reviewed
Mar 15, 2020
Collaborator
nmattia
left a comment
nmattia
left a comment
There was a problem hiding this comment.
LGTM! I can you remove the thread related changes?
Collaborator
Author
|
This was more of an experiment and I intend to remove this. I think the longer term solution is to support |
Collaborator
|
Gotcha, closing this then! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to work around a bug in
builtins.fetchGitwherespecifying a
revwhich is not an ancestor of HEADresults in a git error. When setting
reftorevweforce Nix to fetch the
rev.TODO: This hack can be removed once the following is
merged and released: NixOS/nix#3408