Minor coding style fix: lib.getExe instead of ${bin}/bin/bin #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuflierl
force-pushed
the
patch-2
branch
2 times, most recently
from
43135c6
to
8d14944
Compare
4 tasks
|
Looks good. Thanks for this cleanup! One minor thing: can you fix your commit names to match the style of the other commits in the repository? Will merge afterwards! |
@blitz I believe that everything could be squashed into a single commit. (I was a bit too verbose while making the commits). Would it be fine if I squashed everything into a single commit? I am currently away, so I will take care of it ~8h later |
|
Sure. One commit is fine. 👍 |
RaitoBezarius
approved these changes
Oct 4, 2024
|
Alright, should be fine now |
|
@blitz is the commit name alright? |
flake: add meta.mainProgram attribute to wrappedTool (lzbt)
blitz
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor change in coding style that removes path references replacing them with
lib.getExe.This makes executable references less dependent on binary names.
Major advantage: the
cfg.packageoption doesn't require the binary name to be "lzbt" anymore.