Make home mounts WantedBy a new home-specific target#289
Open
MatthewCash wants to merge 1 commit intonix-community:masterfrom
Open
Make home mounts WantedBy a new home-specific target#289MatthewCash wants to merge 1 commit intonix-community:masterfrom
MatthewCash wants to merge 1 commit intonix-community:masterfrom
Conversation
talyz
requested changes
Jan 11, 2026
Collaborator
talyz
left a comment
There was a problem hiding this comment.
Thanks for working on this!
To support multi-user setups, I think we should assign unique targets per home directory. I think the easiest and most reliable way would be to simply base the target name on the home directory path.
I also think this is worth documenting in the readme :)
4470f39 to
a8f1e40
Compare
Author
|
You're right, I completely forgot about multi-user systems, but that should be fixed now. I also added a section about it to the README, please let me know what you think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I mentioned in #272 that it would be nice to have some way to delay when mounts under the home directory are created for use with home directories mounted on login.
I made all of the mounts under the home directory be dependencies of a new
home-files.target. By default this new target is also a dependency of the normallocal-fs.targetso no ordering actually changes without extra changes. The idea is that someone can override the target'sWantedByproperty and choose specifically when it starts really easily.