Skip to content

Make home mounts WantedBy a new home-specific target#289

Open
MatthewCash wants to merge 1 commit intonix-community:masterfrom
MatthewCash:separate-home-target
Open

Make home mounts WantedBy a new home-specific target#289
MatthewCash wants to merge 1 commit intonix-community:masterfrom
MatthewCash:separate-home-target

Conversation

@MatthewCash
Copy link
Copy Markdown

I mentioned in #272 that it would be nice to have some way to delay when mounts under the home directory are created for use with home directories mounted on login.

I made all of the mounts under the home directory be dependencies of a new home-files.target. By default this new target is also a dependency of the normal local-fs.target so no ordering actually changes without extra changes. The idea is that someone can override the target's WantedBy property and choose specifically when it starts really easily.

Copy link
Copy Markdown
Collaborator

@talyz talyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

To support multi-user setups, I think we should assign unique targets per home directory. I think the easiest and most reliable way would be to simply base the target name on the home directory path.

I also think this is worth documenting in the readme :)

@MatthewCash
Copy link
Copy Markdown
Author

You're right, I completely forgot about multi-user systems, but that should be fixed now.

I also added a section about it to the README, please let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants