Skip to content

neovim: move LUA_(C)PATH setup from wrapping to init.lua#8606

Merged
teto merged 1 commit intonix-community:masterfrom
teto:teto/neovim-inform-lua-dependencies
Jan 22, 2026
Merged

neovim: move LUA_(C)PATH setup from wrapping to init.lua#8606
teto merged 1 commit intonix-community:masterfrom
teto:teto/neovim-inform-lua-dependencies

Conversation

@teto
Copy link
Copy Markdown
Collaborator

@teto teto commented Jan 19, 2026

Motivation is similar to #8586: not relying on wrapped arguments make the neovim install more "natural", or what users are used to. Alternative GUIs can find lua dependencies that are not plugins (for instance nio) without wrapping.
Some plugins depend on lua packages that are not vim plugins and thus become "invisible" to nixpkgs as it stands.
For now they need to be specified manually via extraLuaPackages but hopefully we can autodiscover those in nixpkgs.

I will wait for a bit before merging, to see if #8586 triggered any issue.

TODO:

  • enrich the path only if extraLuaPackages is set

Description

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -p treefmt nixfmt deadnix keep-sorted nixf-diagnose --run treefmt.

  • Code tested through nix run .#tests -- test-all or
    nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.
    • Generate a news entry. See News
    • Basic tests added. See Tests
  • If this PR adds an exciting new feature or contains a breaking change.

    • Generate a news entry. See News

so alternative GUIs can find lua dependencies that are not plugins (for instance nio).
Some plugins depend on lua packages that are not vim plugins and thus
become "invisible" to nixpkgs as it stands.
For now they need to be specified manually via `extraLuaPackages` but
hopefully we can autodiscover those in nixpkgs.
@teto teto force-pushed the teto/neovim-inform-lua-dependencies branch from 38fbbcd to 239fc6a Compare January 20, 2026 23:18
@teto teto marked this pull request as ready for review January 21, 2026 21:26
@home-manager-ci home-manager-ci bot requested a review from khaneliman January 21, 2026 21:27
@teto
Copy link
Copy Markdown
Collaborator Author

teto commented Jan 22, 2026

I was waiting to see if previous PR raised any complaint. Usually it arrives 30mn after a merge. It has been 3 days so I assume it's fine. With this one can finally run neovide (or any neovim derivative) with the generated config. No more wrapping needed.

@teto teto merged commit b0491fe into nix-community:master Jan 22, 2026
8 checks passed
@teto teto deleted the teto/neovim-inform-lua-dependencies branch January 22, 2026 17:24
BerkeleyTrue added a commit to BerkeleyTrue/dotfiles that referenced this pull request Jan 23, 2026
nix-community/home-manager#8606 breaks prev
behavior and tries to clobber users init.lua
@teto teto mentioned this pull request Jan 24, 2026
9 tasks
@teto
Copy link
Copy Markdown
Collaborator Author

teto commented Jan 25, 2026

seems like I forgot to remove extraMakeWrapperLuaCArgs ++ extraMakeWrapperLuaArgs; when cherry-picking so my advice for
xdg.configFile."nvim/init.lua".enable = false just makes things work but it's not as it should be. Opening PR.

teto added a commit to teto/home-manager that referenced this pull request Jan 25, 2026
turns out I forgot to remove the now unnecessary wrapper arguments in
nix-community#8606.
This meant that `xdg.configFile."nvim/init.lua".enable = false` was
enough to fix the user issues but this should not be the case anymore.
teto added a commit to teto/home-manager that referenced this pull request Jan 29, 2026
turns out I forgot to remove the now unnecessary wrapper arguments in
nix-community#8606.
This meant that `xdg.configFile."nvim/init.lua".enable = false` was
enough to fix the user issues but this should not be the case anymore.
teto added a commit that referenced this pull request Jan 29, 2026
turns out I forgot to remove the now unnecessary wrapper arguments in
#8606.
This meant that `xdg.configFile."nvim/init.lua".enable = false` was
enough to fix the user issues but this should not be the case anymore.
repparw pushed a commit to repparw/home-manager that referenced this pull request Jan 30, 2026
turns out I forgot to remove the now unnecessary wrapper arguments in
nix-community#8606.
This meant that `xdg.configFile."nvim/init.lua".enable = false` was
enough to fix the user issues but this should not be the case anymore.
kugland pushed a commit to kugland/home-manager that referenced this pull request Feb 13, 2026
turns out I forgot to remove the now unnecessary wrapper arguments in
nix-community#8606.
This meant that `xdg.configFile."nvim/init.lua".enable = false` was
enough to fix the user issues but this should not be the case anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants