Skip to content

tailscale-systray: add module#7821

Merged
khaneliman merged 1 commit intonix-community:masterfrom
Yethal:add-tailscale-systray-module
Sep 26, 2025
Merged

tailscale-systray: add module#7821
khaneliman merged 1 commit intonix-community:masterfrom
Yethal:add-tailscale-systray-module

Conversation

@Yethal
Copy link
Copy Markdown
Contributor

@Yethal Yethal commented Sep 16, 2025

Description

Added module for official Tailscale systray app

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.

  • Code tested through nix run .#tests -- test-all or
    nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.
    • Generate a news entry. See News
    • Basic tests added. See Tests
  • If this PR adds an exciting new feature or contains a breaking change.

    • Generate a news entry. See News

@Yethal Yethal requested a review from callumio September 16, 2025 09:03
@Yethal
Copy link
Copy Markdown
Contributor Author

Yethal commented Sep 16, 2025

@callumio Adding you as a reviewer since this is 90% copy-pasted from trayscale module

Comment thread modules/services/tailscale-systray.nix Outdated
Comment thread modules/services/tailscale-systray.nix
@Yethal Yethal force-pushed the add-tailscale-systray-module branch 2 times, most recently from 4000dc7 to 9c777c0 Compare September 17, 2025 04:52
@khaneliman
Copy link
Copy Markdown
Collaborator

Could you also add a quick news entry for the new module. nix run .#create-news-entry and then just add a quick blurb

@Yethal Yethal force-pushed the add-tailscale-systray-module branch from 9c777c0 to c8efa47 Compare September 17, 2025 05:07
@Yethal
Copy link
Copy Markdown
Contributor Author

Yethal commented Sep 17, 2025

@khaneliman done

@philiptaron
Copy link
Copy Markdown

I'm interested in reviewing and merging a version of this in Nixpkgs for nixos/modules/services/networking/tailscale.nix.

Comment thread tests/modules/services/tailscale-systray/basic.nix
@khaneliman
Copy link
Copy Markdown
Collaborator

khaneliman commented Sep 26, 2025

Might need to set outPath too, since it's being asserted in the test and not automatically being set anymore.

@Yethal Yethal force-pushed the add-tailscale-systray-module branch 2 times, most recently from 8e6e275 to 5a999dc Compare September 26, 2025 15:10
Comment thread tests/modules/services/tailscale-systray/basic.nix
Comment thread tests/modules/services/tailscale-systray/default.nix Outdated
@Yethal Yethal force-pushed the add-tailscale-systray-module branch from 5a999dc to 02a3407 Compare September 26, 2025 15:11
@Yethal
Copy link
Copy Markdown
Contributor Author

Yethal commented Sep 26, 2025

@khaneliman now we're good

@khaneliman khaneliman enabled auto-merge (squash) September 26, 2025 15:13
@khaneliman khaneliman merged commit 6238bbc into nix-community:master Sep 26, 2025
7 checks passed
@Yethal Yethal deleted the add-tailscale-systray-module branch September 26, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants