xmonad: fix binary name lookup on armv7l when cross-compiled#6795
Merged
khaneliman merged 1 commit intonix-community:masterfrom Apr 10, 2025
Merged
xmonad: fix binary name lookup on armv7l when cross-compiled#6795khaneliman merged 1 commit intonix-community:masterfrom
khaneliman merged 1 commit intonix-community:masterfrom
Conversation
Collaborator
|
Does this need to wait for that? Or can this go in before it hits unstable? |
Contributor
Author
No need, the change is fairly unobtrusive. Without the nixpkgs patch you'll simply fail earlier at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This patch along with NixOS/nixpkgs#397767 allows pre-built xmonad running on
armv7ltarget.GHC converts
armv7land similar to justarmhttps://git.science.uu.nl/f100183/ghc/-/blob/8fa4bf9ab3f4ea4b208f4a43cc90857987e6d497/aclocal.m4#L1874 makinghostPlatform.systempoint toxmonad-arm7l-linuxinstead of correctxmonad-arm-linux.Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allor
nix build --reference-lock-file flake.lock ./tests#test-allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC