Skip to content

xmonad: fix binary name lookup on armv7l when cross-compiled#6795

Merged
khaneliman merged 1 commit intonix-community:masterfrom
sorki:xmonadCross
Apr 10, 2025
Merged

xmonad: fix binary name lookup on armv7l when cross-compiled#6795
khaneliman merged 1 commit intonix-community:masterfrom
sorki:xmonadCross

Conversation

@sorki
Copy link
Copy Markdown
Contributor

@sorki sorki commented Apr 10, 2025

Description

This patch along with NixOS/nixpkgs#397767 allows pre-built xmonad running on armv7l target.

GHC converts armv7l and similar to just arm https://git.science.uu.nl/f100183/ghc/-/blob/8fa4bf9ab3f4ea4b208f4a43cc90857987e6d497/aclocal.m4#L1874 making hostPlatform.system point to xmonad-arm7l-linux instead of correct xmonad-arm-linux.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@khaneliman
Copy link
Copy Markdown
Collaborator

Does this need to wait for that? Or can this go in before it hits unstable?

@sorki
Copy link
Copy Markdown
Contributor Author

sorki commented Apr 10, 2025

Does this need to wait for that? Or can this go in before it hits unstable?

No need, the change is fairly unobtrusive. Without the nixpkgs patch you'll simply fail earlier at xmonad --recompile step.

@khaneliman khaneliman merged commit 543caa3 into nix-community:master Apr 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants