zed-editor: add installRemoteServer option

[GaetanLepage]

Description

Building on top of NixOS/nixpkgs#370017.
This option automatically symlinks the Zed remote server binary to the right location in the user's home directory.
It allows to connect to this host from a remote Zed instance.

See https://wiki.nixos.org/wiki/Zed#Remote_Server for more details.

cc @niklaskorz

Note: Requires NixOS/nixpkgs#370017 to land on the unstable channels.

Checklist

• Change is backwards compatible.

• Code formatted with ./format.

• Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• If this PR adds a new module

  • Added myself as module maintainer. See example.

Maintainer CC

cc @libewa

[libewa]

Looks like the tests didn't run using the latest nixpkgs.

[GaetanLepage]

Looks like the tests didn't run using the latest nixpkgs.

Indeed, the PR in question has not landed to nixos-unstable yet: https://nixpkgs-tracker.ocfox.me/?pr=370017

[GaetanLepage]

0.170.4 is already out... Those guys are a bit too fast !

[niklaskorz]

Tested and works fine for providing the remote server binary on a NixOS server

[teto]

could you test the executable is created at the correct location.
Does it need some special firewall rules ? maybe link towards them directly . Also I would disable it by default. Not everyone wants its machine to be accessible remotely.

I dont think we can setup them from HM alone and a correct approach is out of scope.
Thinking out loud: maybe HM modules could generate iptables scripts for the user to load.

[GaetanLepage]

could you test the executable is created at the correct location.

I did so initially but after a fierce fight against the package-stub implementation of HM tests, I gave up.

Does it need some special firewall rules ?

I don't think so.

Also I would disable it by default. Not everyone wants its machine to be accessible remotely.

Fine by me. WDYT @niklaskorz ?

[niklaskorz]

Does it need some special firewall rules ?

I don't think so.

It only requires an SSH connection, I think it should be left to the user how that is established.

Also I would disable it by default. Not everyone wants its machine to be accessible remotely.

Fine by me. WDYT @niklaskorz ?

Sounds reasonable, although the binary by itself doesn't make the machine remotely accessible (OpenSSH does). But nonetheless, you don't need to download remote_server unless you want to use the machine as a remote server, so that avoids unnecessary downloads for most users.

[GaetanLepage]

Thanks @rycee !

[rycee]

Thanks for the contribution! I made some minor changes and added a basic test. Merged now 🙂