Skip to content

ghostty: Validate configuration on change#6261

Merged
rycee merged 2 commits intonix-community:masterfrom
sestrella:ghostty_validate_config
Jan 4, 2025
Merged

ghostty: Validate configuration on change#6261
rycee merged 2 commits intonix-community:masterfrom
sestrella:ghostty_validate_config

Conversation

@sestrella
Copy link
Copy Markdown
Contributor

@sestrella sestrella commented Jan 3, 2025

Description

Runs ghostty +validate-config when the configuration file changes.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@HeitorAugustoLN

Runs `ghostty +validate-config` when the configuration file changes
Co-authored-by: Heitor Augusto <IAm.HeitorALN@proton.me>
Copy link
Copy Markdown
Member

@HeitorAugustoLN HeitorAugustoLN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this improvement, really useful :)

@rycee rycee merged commit 11ab085 into nix-community:master Jan 4, 2025
@rycee
Copy link
Copy Markdown
Member

rycee commented Jan 4, 2025

Thanks! Merged to master now 🙂

@getchoo getchoo mentioned this pull request Jan 8, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants