firefox, thunderbird: conditional search file

[khaneliman]

Description

When using multiple profiles that share the same path we still try to evaluate the file even when search customization isn't enabled.
Follow up to #5697 (comment) to only evaluate when the profile wants a search.json.mozlz4 file generated.

Checklist

• Change is backwards compatible.

• Code formatted with ./format.

• Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• If this PR adds a new module

  • Added myself as module maintainer. See example.

Maintainer CC

@teto @rycee @kira-bruneau

[khaneliman]

I can try and add a test for this scenario, too. Just wanted to unblock my flake building.

[khaneliman]

Alright, added a test to firefox for the shared path. Verified it throws error without the change and with the change the test passes.

[khaneliman]

Looks like unrelated test failure due to recent neovim PR

neovim-plugin-config: FAILED
Expected /build/tmp.MOi8v4T8TN to contain HM_PLUGINS_CONFIG but it did not.
For further reference please introspect /nix/store/plnzfy7m2c97v07szi1z9w157mhvc54f-nmt-report-neovim-plugin-config

EDIT: I Think @teto is working on it with #5964

[khaneliman]

Rebased and should be good now.

[rycee]

Thanks! Merged to master now 🙂

[teto]

thanks for the fix.

Looks like unrelated test failure due to recent neovim NixOS/nixpkgs#344541

It's annoying that the tests are not run against the flake nixpkgs, it means we cant provide lockstep updates and any nixos-unstable bump can break HM's CI/configs