Skip to content

todoman: add todoman module#5252

Merged
teto merged 3 commits intonix-community:masterfrom
Mikilio:todoman
Jan 9, 2025
Merged

todoman: add todoman module#5252
teto merged 3 commits intonix-community:masterfrom
Mikilio:todoman

Conversation

@Mikilio
Copy link
Copy Markdown
Contributor

@Mikilio Mikilio commented Apr 10, 2024

Adds Mikilio as maintainer for new module for todoman a standards-based task manager based on iCalendar

Description

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@rycee

@Mikilio Mikilio force-pushed the todoman branch 17 times, most recently from cc26020 to 410df5a Compare April 10, 2024 23:34
@Mikilio Mikilio marked this pull request as ready for review April 10, 2024 23:35
Comment thread modules/programs/todoman.nix Outdated
Comment thread modules/programs/todoman.nix Outdated
@rycee
Copy link
Copy Markdown
Member

rycee commented Apr 14, 2024

Thanks for the contribution! I've added a few comments. Also, it would be good to have an simple test to verify that the generated configuration file is as expected.

@Mikilio
Copy link
Copy Markdown
Contributor Author

Mikilio commented Apr 19, 2024

Thanks for the review! By test do you mean something like this?

@Mikilio Mikilio force-pushed the todoman branch 2 times, most recently from 301d6ce to e58ae55 Compare June 5, 2024 00:58
@Mikilio Mikilio requested a review from rycee June 5, 2024 05:42
@Mikilio
Copy link
Copy Markdown
Contributor Author

Mikilio commented Jun 5, 2024

I'm sorry for the delay life has been getting kind of hectic and I figured this was low priority. Everything should be ready to merge now.

@stale
Copy link
Copy Markdown

stale bot commented Sep 6, 2024

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

@stale stale bot added the status: stale label Sep 6, 2024
@Mikilio
Copy link
Copy Markdown
Contributor Author

Mikilio commented Sep 6, 2024

@rycee reminder

@stale stale bot removed the status: stale label Sep 6, 2024
@Mikilio Mikilio force-pushed the todoman branch 2 times, most recently from 21b7d45 to cf1049a Compare October 10, 2024 15:06
Adds Mikilio as maintainer for new module for todoman a standards-based
task manager based on iCalendar

Apply suggestions from code review

Co-authored-by: Robert Helgesson <robert@rycee.net>

Update modules/programs/todoman.nix

Co-authored-by: Robert Helgesson <robert@rycee.net>
@github-actions github-actions bot added shell calendar vdirsyncer, pimsync, ikhal... labels Oct 10, 2024
@github-actions github-actions bot removed shell calendar vdirsyncer, pimsync, ikhal... labels Oct 10, 2024
@Mikilio
Copy link
Copy Markdown
Contributor Author

Mikilio commented Oct 10, 2024

I cleaned up the commits in case this was blocking @rycee

@stale
Copy link
Copy Markdown

stale bot commented Jan 9, 2025

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

@stale stale bot added the status: stale label Jan 9, 2025
@teto
Copy link
Copy Markdown
Collaborator

teto commented Jan 9, 2025

since rycee was ok with the idea of merging such a module and the code looks ok, I merge. I haven't tested it yet and just found out todoman could sync with caldav. nice

@teto teto merged commit d4aebb9 into nix-community:master Jan 9, 2025
@stale stale bot removed the status: stale label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants