Skip to content

gpg-agent: fix unknown variable penentryProgram#5140

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

gpg-agent: fix unknown variable penentryProgram#5140
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Mar 14, 2024

Description

I fixed a issue: error: undefined variable 'pinentryPacakge' from

services.gpg-agent = {
  enable = true;
  pinentryPackage = pkgs.pinentry-curses;
};

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@rycee

Copy link
Copy Markdown
Collaborator

@SebTM SebTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes issues with current master for me 👍🏻

@andresilva
Copy link
Copy Markdown
Contributor

Duplicate of #5139.

@SebTM
Copy link
Copy Markdown
Collaborator

SebTM commented Mar 14, 2024

Yes, but depending on when its get ready/merged I would consider #5141 because it adds a test 🙏🏻

@cpcloud
Copy link
Copy Markdown
Contributor

cpcloud commented Mar 14, 2024

This can be closed now, I added the test from #5141 into #5139.

@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 14, 2024

sorry, didn't see the other MR

@ghost ghost closed this Mar 14, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants