Fix activation under Nix 2.3 and stop run function from discarding error messages

[deviant]

Description

This pull request contains two changes:

treewide: stop run from discarding error messages

Adds a --quiet flag to run, which functions similarly to (but is mutually exclusive with) its existing --silence flag. When applied, this redirects only standard output (unlike --silence, which also redirects standard error) to /dev/null, allowing errors and other diagnostics to be seen. This commit also replaces various usages of --silence with --quiet where the latter seems more appropriate.

Before this change, gratuitous suppression of diagnostic output resulted in me running into the following (rather confusing) failure message:

Feb 25 00:51:03 dysnomia systemd[1]: Starting Home Manager environment for v...
Feb 25 00:51:03 dysnomia hm-activate-v[2558844]: Starting Home Manager activation
Feb 25 00:51:04 dysnomia hm-activate-v[2558844]: Activating checkFilesChanged
Feb 25 00:51:04 dysnomia hm-activate-v[2558844]: Activating checkLinkTargets
Feb 25 00:51:04 dysnomia hm-activate-v[2558844]: Activating writeBoundary
Feb 25 00:51:04 dysnomia hm-activate-v[2558844]: Activating installPackages
Feb 25 00:51:04 dysnomia hm-activate-v[2558844]: Activating linkGeneration
Feb 25 00:51:04 dysnomia hm-activate-v[2558844]: Cleaning up orphan links from /home/v
Feb 25 00:51:04 dysnomia hm-activate-v[2558844]: Creating profile generation 24
Feb 25 00:51:04 dysnomia systemd[1]: home-manager-v.service: Main process exited, code=exited, status=1/FAILURE
Feb 25 00:51:04 dysnomia systemd[1]: home-manager-v.service: Failed with result 'exit-code'.
Feb 25 00:51:04 dysnomia systemd[1]: Failed to start Home Manager environment for v.

With --silence substituted for --quiet, the output instead looks like the following (with the cause of the failure being much more apparent):

Feb 28 23:57:16 dysnomia systemd[1]: Starting Home Manager environment for v...
Feb 28 23:57:16 dysnomia hm-activate-v[3846052]: Starting Home Manager activation
Feb 28 23:57:16 dysnomia hm-activate-v[3846052]: Activating checkFilesChanged
Feb 28 23:57:16 dysnomia hm-activate-v[3846052]: Activating checkLinkTargets
Feb 28 23:57:17 dysnomia hm-activate-v[3846052]: Activating writeBoundary
Feb 28 23:57:17 dysnomia hm-activate-v[3846052]: Activating installPackages
Feb 28 23:57:17 dysnomia hm-activate-v[3846052]: Activating linkGeneration
Feb 28 23:57:17 dysnomia hm-activate-v[3846052]: Cleaning up orphan links from /home/v
Feb 28 23:57:17 dysnomia hm-activate-v[3846052]: Creating profile generation 37
Feb 28 23:57:17 dysnomia hm-activate-v[3846159]: error: path '/home/v/.local/state/home-manager/gcroots/current-home' is not a valid garbage collector root; it's not in the directory '/nix/var/nix/gcroots'
Feb 28 23:57:17 dysnomia systemd[1]: home-manager-v.service: Main process exited, code=exited, status=1/FAILURE
Feb 28 23:57:17 dysnomia systemd[1]: home-manager-v.service: Failed with result 'exit-code'.
Feb 28 23:57:17 dysnomia systemd[1]: Failed to start Home Manager environment for v.

files: fix activation under Nix 2.3

Adds the --indirect flag to a failing nix-store --add-root invocation in the activation script. This flag is required in Nix 2.3 if creating a garbage collector root outside of /nix/var/nix/gcroots. In subsequent versions of Nix, all garbage collector roots created by --add-root are indirect, and the flag is a no-op.

Checklist

• Change is backwards compatible.

• Code formatted with ./format.

• Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

[rycee]

Thanks, that's great! Merged to master now 🙂