gpg-agent: don't set a default for pinentry

[SuperSandro2000]

NixOS stopped building gtk2 pinentry by default in NixOS/nixpkgs#270266 and it does not appear to me that there is a reasonable other default.

Description

Checklist

• Change is backwards compatible.

• Code formatted with ./format.

• Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• If this PR adds a new module

  • Added myself as module maintainer. See example.

Maintainer CC

[cloudlena]

Couldn't using "qt" as the new default also be an option?
For me (using Hyprland), that works well. I think, it might be more user-friendly than not having a default of null.

[SuperSandro2000]

Couldn't using "qt" as the new default also be an option?

I have no idea. I am using kde, so for me this will obviously work but I have no clue about other systems.

[rycee]

Thanks! Merged to master now 🙂

I wonder if perhaps it wouldn't be a good idea to simply remove the nullOr option and leave the option unset so that users are forced to set this explicitly? I can create a PR for that if nobody can think of anything obviously bad about this (beside causing some people's configurations to stop building without adding the explicit option).

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/pinentry-gtk2-contains-only-pinentry-curses/37696/5

[bphenriques]

Is there any official guide on how to upgrade the existing home-manager setups? I use both NixOS (X11 Plasma) and MacOS and the original setup was compatible with both (as I do not do anything system wide in MacOS).

In my case, I was able to sign my commits under both systems but now I cannot. From what I read the gtk2 is very much deprecated.

(This threw me off while I was upgrading some packages - the price to pay for following nix-unstable 😝 )