imapnotify: Use direct nix store path for config#4212
Merged
rycee merged 2 commits intonix-community:masterfrom Jul 9, 2023
Merged
imapnotify: Use direct nix store path for config#4212rycee merged 2 commits intonix-community:masterfrom
rycee merged 2 commits intonix-community:masterfrom
Conversation
github-actions
bot
added
the
mail
As pointed out in nix-community#3291, using the XDG symlink means the agent/unit files don’t change when the contents of the config changes, and so the service will not be restarted.
rycee
force-pushed
the
imapnotify-config-restart
branch
from
38e199d to
e88fac8
Compare
Also add test for the systemd service.
rycee
force-pushed
the
imapnotify-config-restart
branch
from
e88fac8 to
b70db52
Compare
Member
|
Thanks! Made a few fixes, added a systemd test, and merged to master 🙂 |
Contributor
Author
|
Thank you — I haven't had the time this weekend to go through this, but I figured it would be helpful to get started, at least. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out in #3291, using the xdg symlink means the agent/unit files don’t change when the contents of the config changes, and so the service will not be restarted.
I can't test right now.
Description
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allornix develop --ignore-environment .#allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC