tests: fix getOutput on stubs#4050
Merged
rycee merged 1 commit intonix-community:masterfrom Jun 4, 2023
Merged
Conversation
Member
Author
|
Another fix was necessary on top of that because the i3 tests have a stub for |
Setting `outputSpecified` prevents `getOutput` from descending into outputs, which don't have an overridden `outPath`. Additionally, use `__spliced` to permit derivations to use the dummy as an input.
Member
|
Looks good to me! Merged to master now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, stub packages can't be used with
getExe, see #3291 (comment).Setting
outputSpecifiedpreventsgetOutputfrom descending into outputs, which don't have an overriddenoutPath.Alternatives:
outPathin outputs is more codeChecklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allornix develop --ignore-environment .#allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module