Conversation
Contributor
|
See also: #4012 Sorry I didn't see this before writing mine... |
ncfavier
reviewed
May 24, 2023
ncfavier
left a comment
ncfavier
left a comment
Member
There was a problem hiding this comment.
Oops, sorry I didn't see this PR!
| ${if cfg.useBabelfish then '' | ||
| source ${ | ||
| babelfishTranslate hm-session-vars "hm-session-vars" | ||
| } > /dev/null |
Contributor
There was a problem hiding this comment.
The foreign-env version branch uses it (in home-manager, NixOS and nix-darwin); I don't know why. Maybe fenv prints some additional output? babelfish just does a straight translation so it shouldn't be necessary.
Contributor
|
FWIW, this duplicates the generation of |
Member
|
Superseded by #4012 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added useBabelfish option to programs.fish. Speeds up fish startup noticeably. Similar implementation as in NixOS fish module.
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.