services.gpg-agent: darwin compatibility

[elohmeier]

Description

Added compatibility for Darwin to services.gpg-agent.

Checklist

• Change is backwards compatible.

• Code formatted with ./format.

• Code tested through nix-shell --pure tests -A run.all.

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• If this PR adds a new module

  • Added myself as module maintainer. See example.

  • Added myself and the module files to .github/CODEOWNERS.

[ncfavier]

Since #2915, there's no need for the platform conditions any more.

[ncfavier]

We should remove this assertion as well.

[cmacrae]

@elohmeier Thanks for raising this! Great timing, I was just about to open a PR myself, so was delighted to see this.

Not sure how much testing you did on various systems, but with your changes, it doesn't work on macOS Ventura. There are some slight nuances with this module's original intention only being for Linux.

I have an updated version of this that is fully working, also with ssh-agent support working. I also addressed @ncfavier's comments.

If you'd be interested in these contributions, how would you like me to submit them? A PR to your branch?

EDIT: I've also just seen #2964 which addresses nicely some of the nuances I mentioned. It's close to what I have, but admittedly some things handled better :)

[stale]

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

• GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
• If it is unfinished but you plan to finish it, please mark it as a draft.
• If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
• To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

• If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

[elohmeier]

Closing in favor of #2964