Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beets: add mpdIntegration #3755

Merged
merged 1 commit into from
May 11, 2023

Conversation

Scrumplex
Copy link
Member

@Scrumplex Scrumplex commented Mar 9, 2023

Description

Allow configuration of mpdstats and mpdupdate plugins for Beets using Home Manager.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

@Scrumplex Scrumplex requested a review from rycee as a code owner March 9, 2023 14:08
modules/programs/beets.nix Outdated Show resolved Hide resolved
modules/programs/beets.nix Outdated Show resolved Hide resolved
modules/programs/beets.nix Outdated Show resolved Hide resolved
modules/programs/beets.nix Outdated Show resolved Hide resolved
@Scrumplex Scrumplex force-pushed the beets-mpd-integration branch from 0892cb0 to 1d08729 Compare March 9, 2023 14:24
@Scrumplex Scrumplex requested review from ncfavier and removed request for rycee March 9, 2023 14:24
modules/programs/beets.nix Outdated Show resolved Hide resolved
modules/programs/beets.nix Outdated Show resolved Hide resolved
modules/programs/beets.nix Show resolved Hide resolved
@Scrumplex Scrumplex force-pushed the beets-mpd-integration branch 2 times, most recently from a9c4032 to c1d88e2 Compare March 9, 2023 14:46
@Scrumplex
Copy link
Member Author

Hmm. One of the three tests relies on services.mpd, but that isn't available on macOS. What would be the best way to exclude it from macOS tests.

@Scrumplex Scrumplex force-pushed the beets-mpd-integration branch from c1d88e2 to 37c254e Compare March 9, 2023 15:08
@Scrumplex
Copy link
Member Author

Made the tests Linux only for now.

@Scrumplex Scrumplex force-pushed the beets-mpd-integration branch from 37c254e to b9c30f5 Compare March 20, 2023 14:00
Allow configuration of mpdstats and mpdupdate plugins for Beets using
Home Manager.

Signed-off-by: Sefa Eyeoglu <[email protected]>
@Scrumplex Scrumplex force-pushed the beets-mpd-integration branch from b9c30f5 to 49496ae Compare March 20, 2023 14:05
@ncfavier ncfavier merged commit 622fa73 into nix-community:master May 11, 2023
Scrumplex added a commit to Scrumplex/flake that referenced this pull request May 11, 2023
Upstreamed. See nix-community/home-manager#3755

Signed-off-by: Sefa Eyeoglu <[email protected]>
antholeole pushed a commit to antholeole/home-manager that referenced this pull request May 21, 2023
Allow configuration of mpdstats and mpdupdate plugins for Beets using
Home Manager.

Signed-off-by: Sefa Eyeoglu <[email protected]>
sysedwinistrator pushed a commit to sysedwinistrator/home-manager that referenced this pull request May 30, 2023
Allow configuration of mpdstats and mpdupdate plugins for Beets using
Home Manager.

Signed-off-by: Sefa Eyeoglu <[email protected]>
aciceri pushed a commit to aciceri/home-manager that referenced this pull request Jun 16, 2023
Allow configuration of mpdstats and mpdupdate plugins for Beets using
Home Manager.

Signed-off-by: Sefa Eyeoglu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants