Skip to content

firefox: use different paths if librewolf is used#3339

Closed
TilCreator wants to merge 2 commits intonix-community:masterfrom
TilCreator:firefox-path_options
Closed

firefox: use different paths if librewolf is used#3339
TilCreator wants to merge 2 commits intonix-community:masterfrom
TilCreator:firefox-path_options

Conversation

@TilCreator
Copy link
Copy Markdown

@TilCreator TilCreator commented Oct 17, 2022

Description

Makes the mozillaConfigPath, firefoxConfigPath and profilesPath available to the user
#2803 (comment)

Adds handling for the firefox module to use different profile paths if the package is changed to librewolf.
This is kind of a solution for #2803 and #4179

I'm currently not shure how good this solution is and will leave this as a draft and without tests until I used this for a bit and wrote tests.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

@rycee
Copy link
Copy Markdown
Member

rycee commented Oct 20, 2022

Seems like the module could, e.g., look at the browser binaryName to automatically determine these paths for librewolf. I think it would be inappropriate to force such details on the user.

@stale
Copy link
Copy Markdown

stale bot commented Jan 18, 2023

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

@stale stale bot added the status: stale label Jan 18, 2023
@astratagem
Copy link
Copy Markdown

It would be helpful to have these values available. Currently I'm copying the logic into my own config file.

Seeing as the options shouldn't necessarily be configurable since Firefox expects exactly those paths, perhaps these would be more suitable as read-only options? Or alternatively, accessible by way of a function defined in a separate file so that users could import it directly.

@stale stale bot removed the status: stale label Mar 31, 2023
@stale
Copy link
Copy Markdown

stale bot commented Jun 29, 2023

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

@stale stale bot added the status: stale label Jun 29, 2023
@TilCreator TilCreator force-pushed the firefox-path_options branch from c5ebcab to a3ef70d Compare January 11, 2024 18:05
@stale stale bot removed the status: stale label Jan 11, 2024
@TilCreator TilCreator force-pushed the firefox-path_options branch 2 times, most recently from dc5f8a0 to ea0ce0f Compare January 11, 2024 18:08
@TilCreator TilCreator changed the title firefox: make path options available to the user firefox: use different paths if librewolf is used Jan 11, 2024
@TilCreator TilCreator force-pushed the firefox-path_options branch from ea0ce0f to 697dfcd Compare January 24, 2024 21:18
Comment thread modules/programs/firefox.nix
@stale
Copy link
Copy Markdown

stale bot commented Apr 28, 2024

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

@stale stale bot added the status: stale label Apr 28, 2024
@TilCreator TilCreator force-pushed the firefox-path_options branch from 5353cb3 to f5ce32b Compare May 22, 2024 10:55
@github-actions github-actions bot added mail HM email accounts, thunderbird, alot, notmuch, msmtp, meli... neovim shell calendar vdirsyncer, pimsync, ikhal... contacts labels May 22, 2024
@TilCreator TilCreator force-pushed the firefox-path_options branch from f5ce32b to 8cc7793 Compare May 27, 2024 11:01
@github-actions github-actions bot removed mail HM email accounts, thunderbird, alot, notmuch, msmtp, meli... neovim shell calendar vdirsyncer, pimsync, ikhal... labels May 27, 2024
@github-actions github-actions bot removed the contacts label May 27, 2024
@stale stale bot removed the status: stale label May 27, 2024
@TilCreator TilCreator force-pushed the firefox-path_options branch from f85c9b5 to 3b52c83 Compare June 11, 2024 14:01
@rycee rycee closed this in #5128 Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants