firefox: use different paths if librewolf is used#3339
firefox: use different paths if librewolf is used#3339TilCreator wants to merge 2 commits intonix-community:masterfrom
Conversation
|
Seems like the module could, e.g., look at the browser |
|
Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting. If you are the original author of the PR
If you are not the original author of the PR
|
|
It would be helpful to have these values available. Currently I'm copying the logic into my own config file. Seeing as the options shouldn't necessarily be configurable since Firefox expects exactly those paths, perhaps these would be more suitable as read-only options? Or alternatively, accessible by way of a function defined in a separate file so that users could import it directly. |
|
Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting. If you are the original author of the PR
If you are not the original author of the PR
|
c5ebcab to
a3ef70d
Compare
dc5f8a0 to
ea0ce0f
Compare
ea0ce0f to
697dfcd
Compare
|
Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting. If you are the original author of the PR
If you are not the original author of the PR
|
5353cb3 to
f5ce32b
Compare
f5ce32b to
8cc7793
Compare
f85c9b5 to
3b52c83
Compare
Description
Makes themozillaConfigPath,firefoxConfigPathandprofilesPathavailable to the user#2803 (comment)
Adds handling for the firefox module to use different profile paths if the package is changed to librewolf.
This is kind of a solution for #2803 and #4179
I'm currently not shure how good this solution is and will leave this as a draft and without tests until I used this for a bit and wrote tests.
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.