neovim/coc: fix withNodeJs value when enabling coc#3048
Merged
sumnerevans merged 1 commit intonix-community:masterfrom Jun 22, 2022
Merged
neovim/coc: fix withNodeJs value when enabling coc#3048sumnerevans merged 1 commit intonix-community:masterfrom
withNodeJs value when enabling coc#3048sumnerevans merged 1 commit intonix-community:masterfrom
Conversation
1 task
sumnerevans
approved these changes
Jun 22, 2022
Contributor
sumnerevans
left a comment
sumnerevans
left a comment
There was a problem hiding this comment.
Ack, I write too much Python haha. Good catch.
1 task
jevy
pushed a commit
to jevy/home-manager
that referenced
this pull request
Jul 1, 2022
spacekookie
pushed a commit
to spacekookie/home-manager
that referenced
this pull request
Feb 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Coc needs nodejs. This changes the enabling logic to use 'boolean or' instead of an 'attr or default' expression.
Currently, nodejs is enabled by a 'select attrpath or default' expression:
However, the option
neovim.withNodeJsdefaults to false and will exist, which means if you only setneovim.coc.enable = true;then node will be missing.I don't know how to test for this from the test suite, but am willing to try if someone can suggest how to proceed.
CC @sumnerevans Looks like a very minor oversight from #2801
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.