sway: Make onChange script use cfg.package if set#2937
Merged
berbiche merged 1 commit intonix-community:masterfrom May 6, 2022
Merged
sway: Make onChange script use cfg.package if set#2937berbiche merged 1 commit intonix-community:masterfrom
berbiche merged 1 commit intonix-community:masterfrom
Conversation
berbiche
requested changes
May 5, 2022
Member
berbiche
left a comment
berbiche
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
mgurlitz
force-pushed
the
sway-onchange-cfg-package
branch
from
7b7639f to
b71da8f
Compare
mgurlitz
force-pushed
the
sway-onchange-cfg-package
branch
from
b71da8f to
16287bc
Compare
Member
|
@mgurlitz When checking "Commit messages are formatted like …" please make sure that the commit message actually follows the pattern. The checklist is intended to help the reviewer, not mislead them. |
Contributor
Author
|
@rycee My sincere apologies! I had it right in the original PR and then stomped it when fixing the comment from berbiche. |
Member
|
This is also my mistake, I didn't double check the commit message from the web interface 😕 |
Member
|
No worries. Mainly something to keep in mind 🙂 |
jevy
pushed a commit
to jevy/home-manager
that referenced
this pull request
Jul 1, 2022
teto
pushed a commit
to teto/home-manager
that referenced
this pull request
Aug 22, 2022
spacekookie
pushed a commit
to spacekookie/home-manager
that referenced
this pull request
Feb 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On some machines,
pkgs.swayis not usable and thewayland.windowManager.sway.packageconfig can be used to substitute a working version. Howeverpkgs.swayis still used for theonChangescript, so the user may end up with two copies of sway installed or a broken build ifpkgs.swaydoesn't work.Now if the
packageoption is overriden, theonChangescript will callswaymsgwithout pulling inpkgs.sway.Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.I attempted this and was given an error "attribute 'shellDryRun' missing" in modules/programs/bash.nix
Test cases updated/added. See example.
Commit messages are formatted like