Skip to content

tealdeer: add module#2928

Merged
sumnerevans merged 1 commit intonix-community:masterfrom
marsam:add-tealdeer
May 1, 2022
Merged

tealdeer: add module#2928
sumnerevans merged 1 commit intonix-community:masterfrom
marsam:add-tealdeer

Conversation

@marsam
Copy link
Copy Markdown
Contributor

@marsam marsam commented May 1, 2022

Description

Add https://github.com/dbrgn/tealdeer

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

@marsam marsam requested a review from rycee as a code owner May 1, 2022 00:17
Copy link
Copy Markdown
Contributor

@sumnerevans sumnerevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

Comment thread modules/programs/tealdeer.nix
@marsam marsam requested a review from sumnerevans May 1, 2022 00:42
@sumnerevans sumnerevans merged commit 26858fc into nix-community:master May 1, 2022
@sumnerevans
Copy link
Copy Markdown
Contributor

Oh, I think this needed an entry in the news file. @rycee are we still doing those? I haven't seen any lately (possibly because I keep forgetting to request that people add them 👀)

@rycee
Copy link
Copy Markdown
Member

rycee commented May 2, 2022

@sumnerevans I typically still add the news entry when merging the PR. I added one for tealdeer a little while ago.

Dunno if those news entries are particularly useful. Maybe not?

@teto teto mentioned this pull request Aug 22, 2022
7 tasks
teto pushed a commit to teto/home-manager that referenced this pull request Aug 22, 2022
spacekookie pushed a commit to spacekookie/home-manager that referenced this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants