i3-sway: only return current user's socket#2914
Merged
teto merged 1 commit intonix-community:masterfrom Apr 24, 2022
Merged
Conversation
Constrain the pgrep command to only return results for the current user. Additionally, quote the socket variables to prevent splitting. Previously, if multiple users on a system were running `sway`, the `pgrep` used in finding `swaySocket` would return multiple results. As a result, reloads of sway would fail. Fixes nix-community#2912.
teto
approved these changes
Apr 24, 2022
teto
pushed a commit
to teto/home-manager
that referenced
this pull request
Apr 28, 2022
Constrain the pgrep command to only return results for the current user. Additionally, quote the socket variables to prevent splitting. Previously, if multiple users on a system were running `sway`, the `pgrep` used in finding `swaySocket` would return multiple results. As a result, reloads of sway would fail. Fixes nix-community#2912.
teto
pushed a commit
to teto/home-manager
that referenced
this pull request
Aug 22, 2022
Constrain the pgrep command to only return results for the current user. Additionally, quote the socket variables to prevent splitting. Previously, if multiple users on a system were running `sway`, the `pgrep` used in finding `swaySocket` would return multiple results. As a result, reloads of sway would fail. Fixes nix-community#2912.
spacekookie
pushed a commit
to spacekookie/home-manager
that referenced
this pull request
Feb 10, 2023
Constrain the pgrep command to only return results for the current user. Additionally, quote the socket variables to prevent splitting. Previously, if multiple users on a system were running `sway`, the `pgrep` used in finding `swaySocket` would return multiple results. As a result, reloads of sway would fail. Fixes nix-community#2912.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constrain the pgrep command to only return results for the current user.
Additionally, quote the socket variables to prevent splitting.
Previously, if multiple users on a system were running
sway, thepgrepused in findingswaySocketwould return multiple results. As aresult, reloads of sway would fail.
Fixes #2912.
Description
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.shellDryRunbreaks my build #2693 as I don't currently useunstable:Test cases updated/added. See example.
home-managernormally only manages one user at a time. Happy to try to make a test case if someone can give me pointers.Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.