gpg: fix handling of multiple public keys#2897
Closed
wlcx wants to merge 1 commit intonix-community:masterfrom
wlcx:master
Closed
gpg: fix handling of multiple public keys#2897wlcx wants to merge 1 commit intonix-community:masterfrom wlcx:master
wlcx wants to merge 1 commit intonix-community:masterfrom
wlcx:master
Conversation
When processing `publicKeys` entries, handle entries that contain multiple public keys (i.e. gpg --show-key returns multiple `pub` lines) properly, setting the trust level for each key.
rycee
pushed a commit
that referenced
this pull request
Apr 17, 2022
When processing `publicKeys` entries, handle entries that contain multiple public keys (i.e. gpg --show-key returns multiple `pub` lines) properly, setting the trust level for each key. PR #2897
Member
|
Thanks! Rebased to master in 620ed19. |
Contributor
Author
|
Awesome, thanks folks. Any chance we could backport to release-21.11? |
teto
pushed a commit
to teto/home-manager
that referenced
this pull request
Aug 22, 2022
When processing `publicKeys` entries, handle entries that contain multiple public keys (i.e. gpg --show-key returns multiple `pub` lines) properly, setting the trust level for each key. PR nix-community#2897
Member
|
Back-ported to release-21.11 now 🙂
|
spacekookie
pushed a commit
to spacekookie/home-manager
that referenced
this pull request
Feb 10, 2023
When processing `publicKeys` entries, handle entries that contain multiple public keys (i.e. gpg --show-key returns multiple `pub` lines) properly, setting the trust level for each key. PR nix-community#2897
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When processing
publicKeysentries, handle entries that contain multiple public keys (i.e. gpg --show-key returns multiplepublines) properly, setting the trust level for each key.Previously, multiple
pubentries caused an error, since the keyids separated by newlines were passed straight togpg --edit-key.Checklist
Change is backwards compatible. Single keys still work fine.
Code formatted with
./format. Manually formatted withnixfmtCode tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.