i3-sway: empty set argument was passed to wrong function#2819
Merged
sumnerevans merged 1 commit intonix-community:masterfrom Mar 22, 2022
Merged
Conversation
sumnerevans
approved these changes
Mar 22, 2022
stephaneyfx
force-pushed
the
fix-optionals-call-in-i3-sway
branch
from
e259fde to
fe81560
Compare
Contributor
Author
|
Thank you for your review @sumnerevans! It turns out the empty set argument was needed; it was just passed to the wrong function ( |
sumnerevans
changed the title
optionals
This would give the error "attempt to call something which is not a function but a list" given that `optionals a b` returns a list. `indent` is the one taking this empty set as second argument.
stephaneyfx
force-pushed
the
fix-optionals-call-in-i3-sway
branch
from
fe81560 to
ef1c368
Compare
Contributor
Author
|
I forgot to run the formatting tool this time around so I had to push again. Sorry for the noise and thank you for restarting the tests. |
jficz
pushed a commit
to jficz/home-manager
that referenced
this pull request
Apr 7, 2022
…ty#2819) This would give the error "attempt to call something which is not a function but a list" given that `optionals a b` returns a list. `indent` is the one taking this empty set as second argument.
teto
pushed a commit
to teto/home-manager
that referenced
this pull request
Aug 22, 2022
…ty#2819) This would give the error "attempt to call something which is not a function but a list" given that `optionals a b` returns a list. `indent` is the one taking this empty set as second argument.
spacekookie
pushed a commit
to spacekookie/home-manager
that referenced
this pull request
Feb 10, 2023
…ty#2819) This would give the error "attempt to call something which is not a function but a list" given that `optionals a b` returns a list. `indent` is the one taking this empty set as second argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would give the error "attempt to call something which is not a
function but a list" given that
optionals a breturns a list.Description
This fixes the following error when running
home-manager switchandswayis used in the configuration:Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.