Skip to content

tmux: fix broken vi bindings#2817

Merged
sumnerevans merged 1 commit intonix-community:masterfrom
nbardiuk:fix-tmux-notes
Mar 21, 2022
Merged

tmux: fix broken vi bindings#2817
sumnerevans merged 1 commit intonix-community:masterfrom
nbardiuk:fix-tmux-notes

Conversation

@nbardiuk
Copy link
Copy Markdown
Contributor

Description

Keybindings have wrong order of arguments: the -N flag should go before the binding key. https://www.man7.org/linux/man-pages/man1/tmux.1.html#KEY_BINDINGS

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

@nbardiuk nbardiuk requested a review from rycee as a code owner March 21, 2022 20:00
Copy link
Copy Markdown
Contributor

@sumnerevans sumnerevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you please rebase on the latest master so the tests pass?

Keybindings have wrong order of arguments: the -N flag should go before
the binding key
@sumnerevans sumnerevans merged commit bbc5e0c into nix-community:master Mar 21, 2022
@nbardiuk nbardiuk deleted the fix-tmux-notes branch March 22, 2022 09:43
jficz pushed a commit to jficz/home-manager that referenced this pull request Apr 7, 2022
Keybindings have wrong order of arguments: the -N flag should go before
the binding key
@teto teto mentioned this pull request Aug 22, 2022
7 tasks
teto pushed a commit to teto/home-manager that referenced this pull request Aug 22, 2022
Keybindings have wrong order of arguments: the -N flag should go before
the binding key
spacekookie pushed a commit to spacekookie/home-manager that referenced this pull request Feb 10, 2023
Keybindings have wrong order of arguments: the -N flag should go before
the binding key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants