Skip to content

Fix tests for herbstluftwm and mpd (bash-version)#2816

Merged
sumnerevans merged 2 commits intonix-community:masterfrom
SebTM:20220321_fix_tests
Mar 21, 2022
Merged

Fix tests for herbstluftwm and mpd (bash-version)#2816
sumnerevans merged 2 commits intonix-community:masterfrom
SebTM:20220321_fix_tests

Conversation

@SebTM
Copy link
Copy Markdown
Collaborator

@SebTM SebTM commented Mar 21, 2022

Description

Fix current failing tests for herbstluftwm and mpd.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

@SebTM SebTM requested a review from rycee as a code owner March 21, 2022 12:48
@SebTM SebTM changed the title 20220321 fix tests Fix tests for herbstluftwm and mpd (bash-version) Mar 21, 2022
Copy link
Copy Markdown
Contributor

@sumnerevans sumnerevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Beat me to it :)

@sumnerevans sumnerevans merged commit 6482306 into nix-community:master Mar 21, 2022
@SebTM SebTM deleted the 20220321_fix_tests branch March 21, 2022 21:42
@ncfavier
Copy link
Copy Markdown
Member

Opened https://gitlab.com/rycee/nmt/-/merge_requests/5 so we don't have to keep doing this

jficz pushed a commit to jficz/home-manager that referenced this pull request Apr 7, 2022
* mpd: Fix bash-version in tests

* herbstluftwm: Fix bash-version in tests
@teto teto mentioned this pull request Aug 22, 2022
7 tasks
teto pushed a commit to teto/home-manager that referenced this pull request Aug 22, 2022
* mpd: Fix bash-version in tests

* herbstluftwm: Fix bash-version in tests
spacekookie pushed a commit to spacekookie/home-manager that referenced this pull request Feb 10, 2023
* mpd: Fix bash-version in tests

* herbstluftwm: Fix bash-version in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants